Afit 124

[wpierozak]

No description provided.

[github-actions]

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

[alibuild]

Error while checking build/O2/fullCI_slc9 for a8b6f71 at 2026-01-22 15:20:

No log files found

Full log here.

[shahor02]

Hi @wpierozak @sahilupadhyaya92 @andreasmolander

this PR had a bug (fixed by #15088): the FV0 channels associated with recpoints were accumulated on top of previous TFs data. As far as I understand, this means that the channels data stored in the AO2D makes no sense. Do you have a fast way to check the AOD content for data already produced with the affected tag:
LHC25aj: https://alimonitor.cern.ch/prod/jobs.jsp?t=33347
LHC25ak: https://alimonitor.cern.ch/prod/jobs.jsp?t=33348

Would be good to check the whole FIT output in the AOD, as this PR was quite massive...

Pinging to @catalinristea

[sahilupadhyaya92]

Hi @shahor02

Thanks for spotting this and for the quick fix.
This PR mainly pertains to FV0 dead channel map, so I am sure that FT0 and FDD data are ok.
We will check the affected datasets soon.

[sahilupadhyaya92]

Hi @shahor02
I confirm the overwriting of channel data in the affected datasets
Example plot attached.

I hope you already have the new corrected datasets after your fix...

[shahor02]

Thanks @sahilupadhyaya92 ! Pinging to @catalinristea : part of data was processed with buggy code so the AODs are affected. I guess these runs should be reprocessed.

[shahor02]

PS: @sahilupadhyaya92 just to be sure: which data did you use for these plots?
The problematic productions I've indicated in the 1st message were done with daily O2 and then redone with the tag including a fix, so the https://alimonitor.cern.ch/prod/jobs.jsp?t=33347 now contains fixed AO2Ds

[sahilupadhyaya92]

@shahor02
This plot shown above was made by running reco over CTFs with 3 different tags (before this PR, after this PR, after the fix).
We also have the output of our fv0-qa task run on problematic AO2Ds.
If you want to see, then we can provide a comparison between AO2Ds as well.

[shahor02]

Thanks @sahilupadhyaya92 ! Just wanted to be sure that there is not corrupted data left.