Skip to content

[PWGCF] FemtoUniverse: Add deta constrain in CPR with fractions of separation#13094

Merged
prchakra merged 2 commits intoAliceO2Group:masterfrom
prchakra:master
Sep 24, 2025
Merged

[PWGCF] FemtoUniverse: Add deta constrain in CPR with fractions of separation#13094
prchakra merged 2 commits intoAliceO2Group:masterfrom
prchakra:master

Conversation

@prchakra
Copy link
Copy Markdown
Collaborator

@prchakra prchakra commented Sep 23, 2025

No description provided.

@github-actions github-actions bot added the pwgcf label Sep 23, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 23, 2025 •
edited
Loading

O2 linter results: ❌ 30 errors, ⚠️ 0 warnings, 🔕 0 disabled

lauraser
lauraser reviewed Sep 23, 2025
View reviewed changes
PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h Outdated
histdetadpimixed[i][0]->Fill(deta, dphiAvg);
} else {
LOG(fatal) << "FemtoUniverseDetaDphiStar: passed arguments don't agree with FemtoUniverseDetaDphiStar's type of events! Please provide same or mixed.";
if (ChosenEventType if (distfrac > FracMax) {
Copy link
Copy Markdown
Collaborator

@lauraser lauraser Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a bug?

Copy link
Copy Markdown
Collaborator Author

@prchakra prchakra Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lauraser, yes, I am fixing it.

PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h Outdated
"detadphidetadphi0AfterMixed_3", "detadphidetadphi0AfterMixed_4", "detadphidetadphi0AfterMixed_5",
"detadphidetadphi0AfterMixed_6", "detadphidetadphi0AfterMixedqLCMS"}};

static constexpr std::string_view HistNamesRadii[7][9] = {{"detadphidetadphi0Before_0_0", "detadphidetadphi0Before_0_1", "detadphidetadphi0Before_0_2",
Copy link
Copy Markdown
Collaborator

@lauraser lauraser Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be better done in a loop

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Sep 23, 2025

Error while checking build/O2Physics/o2 for 7ec9126 at 2025-09-23 21:30:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:847:2: error: expected ';' after class definition
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:55:5: error: 'chosenRadii' was not declared in this scope; did you mean 'lchosenradii'?
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:56:5: error: 'cutDeltaPhiStarMax' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:57:5: error: 'cutDeltaPhiStarMin' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:58:5: error: 'cutDeltaEtaMax' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:59:5: error: 'cutDeltaEtaMin' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:60:5: error: 'plotForEveryRadii' was not declared in this scope; did you mean 'lplotForEveryRadii'?
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:61:5: error: 'mHistogramRegistry' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:62:5: error: 'mHistogramRegistryQA' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:63:5: error: 'cutPhiInvMassLow' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:64:5: error: 'cutPhiInvMassHigh' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:65:5: error: 'isSameSignCPR' was not declared in this scope; did you mean 'lisSameSignCPR'?
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:67:19: error: 'kPartOneType' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:67:91: error: 'kPartTwoType' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:68:54: error: 'DirNames' was not declared in this scope; did you mean 'dirName'?
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:69:7: error: 'histdetadpisame' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:69:58: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:69:96: error: 'HistNamesSame' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:69:164: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:69:164: error: expected ')' before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:70:58: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:70:164: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:70:164: error: expected ')' before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:71:7: error: 'histdetadpimixed' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:71:59: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:71:97: error: 'HistNamesMixed' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:71:166: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:71:166: error: expected ')' before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:72:59: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:72:166: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:72:166: error: expected ')' before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:74:7: error: 'histdetadpiqlcmssame' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:74:57: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:74:178: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:74:178: error: expected ')' before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:75:7: error: 'histdetadpiqlcmsmixed' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:75:58: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:75:180: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:75:180: error: expected ')' before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:79:11: error: 'histdetadpiRadii' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:79:65: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:79:103: error: 'HistNamesRadii' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:79:172: error: expected primary-expression before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:79:172: error: expected ')' before '{' token
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:83:19: error: 'kPartOneType' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:83:91: error: 'kPartTwoType' was not declared in this scope
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:85:56: error: 'DirNames' was not declared in this scope; did you mean 'dirName'?
/sw/SOURCES/O2Physics/13094-slc9_x86-64/0/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:86:9: error: 'histdetadpisame' was not declared in this scope
[0 more errors; see full log]

Full log here.

@prchakra prchakra enabled auto-merge (squash) September 24, 2025 06:52
alibuild
alibuild approved these changes Sep 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @prchakra.

@prchakra prchakra merged commit 2feaa46 into AliceO2Group:master Sep 24, 2025
11 of 12 checks passed
jmunozme pushed a commit to jmunozme/O2Physics that referenced this pull request Oct 3, 2025
@prchakra @alibuild @jmunozme
[PWGCF] FemtoUniverse: Add deta constrain in CPR with fractions of se…
e36742e 
…paration (AliceO2Group#13094)

Co-authored-by: ALICE Action Bot <[email protected]>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
@prchakra @alibuild @jinhyunni
[PWGCF] FemtoUniverse: Add deta constrain in CPR with fractions of se…
fef0991 
…paration (AliceO2Group#13094)

Co-authored-by: ALICE Action Bot <[email protected]>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@prchakra @alibuild @ThePhDane
[PWGCF] FemtoUniverse: Add deta constrain in CPR with fractions of se…
45aa6c9 
…paration (AliceO2Group#13094)

Co-authored-by: ALICE Action Bot <[email protected]>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@prchakra @alibuild @jloemker
[PWGCF] FemtoUniverse: Add deta constrain in CPR with fractions of se…
a96b2ad 
…paration (AliceO2Group#13094)

Co-authored-by: ALICE Action Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lauraser lauraser lauraser left review comments

@alibuild alibuild alibuild approved these changes

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@zchochul zchochul Awaiting requested review from zchochul

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prchakra @alibuild @lauraser