[PWGHF] Fix missing McCollisions and refactor MC histograms into subdirectories in taskLcToK0sP.cxx#16541
[PWGHF] Fix missing McCollisions and refactor MC histograms into subdirectories in taskLcToK0sP.cxx#16541dongfangqingxin wants to merge 3 commits into
Conversation
|
O2 linter results: ❌ 0 errors, |
|
Error while checking build/O2Physics/o2 for 4ac3499 at 2026-06-05 18:09: Full log here. |
|
Error while checking build/O2Physics/staging for 4ac3499 at 2026-06-05 18:13: Full log here. |
| @@ -460,6 +575,16 @@ struct HfTaskLcToK0sP { | |||
| if (std::abs(candidate.flagMcMatchRec()) == KDecayChannelLcToK0sP) { | |||
There was a problem hiding this comment.
This is wrong. Compare against the actual filled constant.
There was a problem hiding this comment.
This is wrong. Compare against the actual filled constant.
Hi @vkucera, since there's no Λc+ → pK0s decay channel defined in PWGHF/Core/DecayChannels.h, so I defined one locally ('KDecayChannelLcToK0sP = 1') in the task, following what's done in taskCharmPolarisation.cxx. What should I do in this case?
There was a problem hiding this comment.
I see. It would be worth defining it in the proper place at some point. Not strictly needed in this PR.
What does K mean though?
There was a problem hiding this comment.
Hi @vkucera The 'K' prefix has no special meaning — I just want to follow the ROOT naming convention for constants (e.g., 'kRed'). I can remove it if you wish.
There was a problem hiding this comment.
This is not ROOT. This is O2. Please follow the correct conventions.
|
@dongfangqingxin Did you check for warnings in your compilation? |
Hi @vkucera Thanks for the comments! I used a script that only catches errors, not warnings and I did not check log manually — my bad. I'm going to drop the extractCandVars template and just repeat the code instead. |
Why do you want to drop it? |
Since both alibuild and the O2 linter were complaining about the template I and figured removing it was the quickest fix |
…l/prompt/nonprompt/background subdirectories - Add missing McCollisions dependency - Reorganise MC/Rec and MC/Gen histograms into signal/prompt/nonprompt/background subdirectories - Code clean up
O2 linter did not complain about the template and the compilation warning was about a narrowing |
|
Do not force-push. You just overwrote the commit that I have reviewed. It's explicitly forbidden in the instructions. |
@vkucera Sorry about the force-push, won't happen again. I'll add new commits from now on. I kept the template and all your comments have been addressed in the latest version, except the one about KDecayChannelLcToK0sP — do you have any suggestion for it? |
Yes, your are right! I renamed it to HfCandVars to fix the O2 linter error, and changed the member types from float to double to fix the narrowing conversion warning. |
taskLcToK0sP.cxx was Updated in this PR