Glasgow | SDC NOV 2025 | Katarzyna Kazimierczuk | Sprint 1 | Analyse and refactor#116
Open
katarzynakaz wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
Glasgow | SDC NOV 2025 | Katarzyna Kazimierczuk | Sprint 1 | Analyse and refactor#116katarzynakaz wants to merge 4 commits intoCodeYourFuture:mainfrom
katarzynakaz wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
katarzynakaz
added
Needs Review
SlideGauge
added
the
Review in progress
SlideGauge
reviewed
Mar 1, 2026
SlideGauge
left a comment
SlideGauge
left a comment
There was a problem hiding this comment.
Overall good job, made several notes in various places. My main note from several places (both js and python): sometimes there are situations when dict is used with a mapping object->boolean, and purpose is to mark the presence of the element only. It could be achieved with a similar datastructure which is a bit lighter in memory consumption, as it tracks key presence only.
Sprint-1/JavaScript/calculateSumAndProduct/calculateSumAndProduct.js
Outdated
Show resolved
Hide resolved
SlideGauge
added
Reviewed
katarzynakaz
added
the
Needs Review
Author
|
thank you! |
SlideGauge
added
Review in progress
SlideGauge
reviewed
Mar 3, 2026
|
Just a couple of tiny things to fix and I'll accept the review |
SlideGauge
added
Reviewed
Author
|
thank you very much, issues fixed |
|
Very nice, approved |
SlideGauge
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
The pr includes completed tasks in refactoring to optimise complexity and includes js and python tasks.