Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 1 | Big-O notation and refactoring#95
Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 1 | Big-O notation and refactoring#95Nataliia74 wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
Nataliia74
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Nataliia74
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Nataliia74
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
I think in this exercise,
"Time Complexity" is supposed to be the complexity of the original code, and
"Optimal Time Complexity" is the complexity of the refactored code.
Can you also describe the complexity of the original code?
| let firstArr = new Set(firstArray); | ||
| let secondArr = new Set(secondArray); |
There was a problem hiding this comment.
For variables that do not need to be reassigned a value, better practice is to declare them using const.
| let firstArr = new Set(firstArray); | ||
| let secondArr = new Set(secondArray); | ||
|
|
||
| return [...firstArr].filter((arr) => secondArr.has(arr)); |
There was a problem hiding this comment.
Note: Set has a built-in method for finding common elements between two sets.
cjyuan
added
Reviewed
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
2 participants
Learners, PR Template
Self checklist
I used to solve these tasks with a hash set(based on hash table logic, which is very fast in terms of time complexity) for constant-time lookups and processes each element once. In addition, for JS logic new Set also keeps ordering along with deduplication.