PANA-5681: Integrate HeatmapIdentifierRegistry into RUM for heatmaps [3 of 4]#3205
Merged
jonathanmos merged 5 commits intoJun 1, 2026
Merged
Conversation
3 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 087cbc56d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
gonzalezreal
force-pushed
the
gonzalezreal/PANA-5681/rum-heatmaps
branch
from
7c039dc to
e76417d
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/heatmaps #3205 +/- ##
====================================================
+ Coverage 72.09% 72.11% +0.02%
====================================================
Files 964 967 +3
Lines 35429 35499 +70
Branches 5880 5887 +7
====================================================
+ Hits 25542 25600 +58
- Misses 8278 8283 +5
- Partials 1609 1616 +7
🚀 New features to boost your workflow:
|
jonathanmos
changed the title
jonathanmos
force-pushed
the
gonzalezreal/PANA-5681/schema-updates
branch
from
ec4040e to
81e4f04
Compare
Base automatically changed from
gonzalezreal/PANA-5681/schema-updates
to
feature/heatmaps
May 13, 2026 11:51
jonathanmos
force-pushed
the
gonzalezreal/PANA-5681/rum-heatmaps
branch
2 times, most recently
from
cbfbf76 to
9a2e330
Compare
jonathanmos
changed the title
jonathanmos
force-pushed
the
gonzalezreal/PANA-5681/rum-heatmaps
branch
from
9a2e330 to
e63b7f4
Compare
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
kikoveiga
previously approved these changes
May 25, 2026
0xnm
previously approved these changes
May 26, 2026
jonathanmos
force-pushed
the
gonzalezreal/PANA-5681/rum-heatmaps
branch
from
eef69a5 to
6210b4b
Compare
jonathanmos
force-pushed
the
gonzalezreal/PANA-5681/rum-heatmaps
branch
from
6210b4b to
fa8baf8
Compare
aleksandr-gringauz
previously approved these changes
May 28, 2026
0xnm
reviewed
May 28, 2026
| * = true on Android but never receive touch events, so the RUM gesture layer never fires for | ||
| * them. Excluding `isEnabled` here keeps the predicate identical to RUM's existing behaviour. | ||
| */ | ||
| fun View.isValidTapTarget(): Boolean { |
Member
There was a problem hiding this comment.
do we need to have it in -internal module? seems like it is used only in -rum.
normally -internal module shouldn't be visible on the user side, but if they add it, they will have this extension.
Member
There was a problem hiding this comment.
It will be used also by session replay in the next pr
0xnm
previously approved these changes
Jun 1, 2026
0xnm
approved these changes
Jun 1, 2026
aleksandr-gringauz
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Integrates heatmap tap data into the RUM feature. When a tap gesture is detected and the view is attached to a window, GesturesListener captures the touch coordinates, the view's dimensions, and (when available) its heatmap identifier from the
HeatmapIdentifierRegistry, and packages them into a newHeatmapActionDataobject. This data flows throughAdvancedRumMonitor.addActionWithHeatmap— an internal API that keepsHeatmapActionDataoff the publicRumMonitorinterface — intoRumActionScope, where it is serialised into thedd.actionfield of the outgoingActionEvent.RumFeaturenow implementsHeatmapIdentifierRegistryProvider, exposing its lazily-initialised registry to Session Replay viaFeatureScope.unwrap()without going through the untyped feature-context map.Motivation
Support mobile heatmaps. This is PR 3 of 4, integrates the
HeatmapIdentifierRegistry(#3202) and updated schemas (#3203) into RUM.Additional Notes
Review checklist (to be filled by reviewers)