Repository navigation
test(strings): cover Unicode whitespace and sentinel boundaries - #519
Merged
JohnnyWilson16 merged 1 commit intoOct 13, 2026
Merged
JohnnyWilson16 merged 1 commit into
JohnnyWilson16 merged 1 commit into
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
JohnnyWilson16
approved these changes
Oct 13, 2026
JohnnyWilson16
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thorough test coverage for #498. Correctly verifies U+00A0 stripping, U+200B preservation, and audit report counts across string and object dtypes without test flakiness. Ready to merge.
JohnnyWilson16
marked this pull request as ready for review
October 13, 2026 12:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add six requested Unicode regression cases to
tests/test_strings.pyfor object and pandas string columns. They cover defaultfd.clean()and explicit stripping, NBSP-padded sentinels/values, zero-width-space content, internal spacing, repair counts, and stripping disabled. Populated row identifiers keep sentinel-to-missing conversions observable without dropping rows.NBSP is stripped at cell boundaries and can expose a sentinel; U+200B follows the existing Python whitespace rules and remains content. This PR changes tests only.
Fixes #498.
Validation:
pytest tests/test_strings.py --no-cov: all 29 cases pass on pandas 2.3.3; 26 pass and three existing Arrow cases skip on pandas 1.5.3.main@ba3f01fin this Windows environment, 94.98% coverage.Draft pending #518: the floating Polars 2.0 matrix has an existing all-columns-dropped parity failure, addressed by that PR. Keep this test-only scope separate; refresh from main and mark ready after the fix lands and hosted checks pass.