Problems with importing Thorlabs lenses

[raulcantos]

Hi, I was not certain if this was an issue or a discussion but given how little information i can provide I think this format fits best.
I was trying to import a number of thorlabs lenses into Optiland but none of them work. This is one of them https://www.thorlabs.com/thorproduct.cfm?partnumber=LJ1598L1. I haven't been able to import any of the Thorlab's cylindrical lenses, i get ValueError: Unsupported surface type. However, the examples from the docs, and other examples shown here are working for me. Any idea of what might be happening?

[HarrisonKramer]

Hi @raulcantos,

Thanks for opening this.

File import is failing simply because the Zemax file reader does not currently support the reading of toroidal (or cylindrical) surfaces. I have already looked into how we can update this, such that this surface type is supported. It will be a relatively straightforward update. I will also plan to make the error for unsupported surface types more descriptive.

I have opened an issue to track this feature request: #398

Regards,
Kramer

[HarrisonKramer]

And this feature was added in #399, so it now works in the latest master branch.

[raulcantos]

Thank you so much, it's awesome the work that you are doing. Please keep it up :)