diff --git a/hypha/apply/activity/adapters/emails.py b/hypha/apply/activity/adapters/emails.py index 8f033d1401..e94ed8eda7 100644 --- a/hypha/apply/activity/adapters/emails.py +++ b/hypha/apply/activity/adapters/emails.py @@ -13,7 +13,7 @@ CoApplicantProjectPermission, CoApplicantRole, ) -from hypha.apply.projects.models.payment import ( +from hypha.apply.projects.models.invoice import ( APPROVED_BY_FINANCE, CHANGES_REQUESTED_BY_FINANCE, CHANGES_REQUESTED_BY_STAFF, diff --git a/hypha/apply/activity/adapters/slack.py b/hypha/apply/activity/adapters/slack.py index bef0014dc0..fda4fc896a 100644 --- a/hypha/apply/activity/adapters/slack.py +++ b/hypha/apply/activity/adapters/slack.py @@ -8,7 +8,7 @@ from hypha.apply.activity.adapters.base import AdapterBase from hypha.apply.activity.adapters.utils import link_to, reviewers_message from hypha.apply.activity.options import MESSAGES -from hypha.apply.projects.models.payment import ( +from hypha.apply.projects.models.invoice import ( APPROVED_BY_STAFF, CHANGES_REQUESTED_BY_FINANCE, PAID, diff --git a/hypha/apply/activity/adapters/utils.py b/hypha/apply/activity/adapters/utils.py index 8c0ad9a549..30578707c6 100644 --- a/hypha/apply/activity/adapters/utils.py +++ b/hypha/apply/activity/adapters/utils.py @@ -5,7 +5,7 @@ from hypha.apply.activity.options import MESSAGES from hypha.apply.projects.models import ProjectSettings -from hypha.apply.projects.models.payment import ( +from hypha.apply.projects.models.invoice import ( APPROVED_BY_FINANCE, CHANGES_REQUESTED_BY_STAFF, DECLINED, diff --git a/hypha/apply/activity/tests/test_adapter_utils.py b/hypha/apply/activity/tests/test_adapter_utils.py index 30f7dc8f3a..db37330a13 100644 --- a/hypha/apply/activity/tests/test_adapter_utils.py +++ b/hypha/apply/activity/tests/test_adapter_utils.py @@ -3,7 +3,7 @@ from django.test import SimpleTestCase, TestCase from hypha.apply.activity.options import MESSAGES -from hypha.apply.projects.models.payment import ( +from hypha.apply.projects.models.invoice import ( APPROVED_BY_FINANCE, APPROVED_BY_STAFF, CHANGES_REQUESTED_BY_STAFF, diff --git a/hypha/apply/dashboard/tests/test_views.py b/hypha/apply/dashboard/tests/test_views.py index a96b3b252c..f2a9b2b94d 100644 --- a/hypha/apply/dashboard/tests/test_views.py +++ b/hypha/apply/dashboard/tests/test_views.py @@ -6,7 +6,7 @@ ApplicationSubmissionFactory, InvitedToProposalFactory, ) -from hypha.apply.projects.models.payment import ( +from hypha.apply.projects.models.invoice import ( APPROVED_BY_STAFF, CHANGES_REQUESTED_BY_STAFF, DECLINED, diff --git a/hypha/apply/dashboard/views.py b/hypha/apply/dashboard/views.py index e8505088f4..3e71979b31 100644 --- a/hypha/apply/dashboard/views.py +++ b/hypha/apply/dashboard/views.py @@ -18,7 +18,7 @@ ) from hypha.apply.projects.filters import ProjectListFilter from hypha.apply.projects.models import Invoice, Project, ProjectSettings -from hypha.apply.projects.models.payment import DECLINED, PAID +from hypha.apply.projects.models.invoice import DECLINED, PAID from hypha.apply.projects.tables import ( InvoiceDashboardTable, PAFForReviewDashboardTable, diff --git a/hypha/apply/projects/constants.py b/hypha/apply/projects/constants.py index ce689ae75b..88a08e5f68 100644 --- a/hypha/apply/projects/constants.py +++ b/hypha/apply/projects/constants.py @@ -1,7 +1,7 @@ from django.conf import settings from django.utils.translation import gettext_lazy as _ -from .models.payment import ( +from .models.invoice import ( APPROVED_BY_FINANCE, APPROVED_BY_STAFF, CHANGES_REQUESTED_BY_FINANCE, diff --git a/hypha/apply/projects/filters.py b/hypha/apply/projects/filters.py index efda59cf2b..0b13cebbbd 100644 --- a/hypha/apply/projects/filters.py +++ b/hypha/apply/projects/filters.py @@ -10,7 +10,7 @@ get_used_funds, ) -from .models.payment import INVOICE_STATUS_CHOICES, Invoice +from .models.invoice import INVOICE_STATUS_CHOICES, Invoice from .models.project import ( CLOSING, INVOICING_AND_REPORTING, diff --git a/hypha/apply/projects/forms/__init__.py b/hypha/apply/projects/forms/__init__.py index f874f17084..a8dd172dfa 100644 --- a/hypha/apply/projects/forms/__init__.py +++ b/hypha/apply/projects/forms/__init__.py @@ -1,4 +1,4 @@ -from .payment import ( +from .invoice import ( BatchUpdateInvoiceStatusForm, ChangeInvoiceStatusForm, CreateInvoiceForm, diff --git a/hypha/apply/projects/forms/payment.py b/hypha/apply/projects/forms/invoice.py similarity index 99% rename from hypha/apply/projects/forms/payment.py rename to hypha/apply/projects/forms/invoice.py index 7fffef4637..872c12e62e 100644 --- a/hypha/apply/projects/forms/payment.py +++ b/hypha/apply/projects/forms/invoice.py @@ -11,7 +11,7 @@ from hypha.apply.funds.widgets import MultiCheckboxesWidget from hypha.apply.stream_forms.fields import MultiFileField, SingleFileField -from ..models.payment import ( +from ..models.invoice import ( APPROVED_BY_FINANCE, APPROVED_BY_STAFF, CHANGES_REQUESTED_BY_FINANCE, diff --git a/hypha/apply/projects/migrations/0014_add_payment_related_models.py b/hypha/apply/projects/migrations/0014_add_payment_related_models.py index 30b4e21f45..c75c8e139c 100644 --- a/hypha/apply/projects/migrations/0014_add_payment_related_models.py +++ b/hypha/apply/projects/migrations/0014_add_payment_related_models.py @@ -74,7 +74,7 @@ class Migration(migrations.Migration): "invoice", models.FileField( storage=django.core.files.storage.FileSystemStorage(), - upload_to=hypha.apply.projects.models.payment.invoice_path, + upload_to=hypha.apply.projects.models.invoice.invoice_path, ), ), ( diff --git a/hypha/apply/projects/migrations/0037_add_project_invoicing.py b/hypha/apply/projects/migrations/0037_add_project_invoicing.py index e56c5fe793..f2ab875390 100644 --- a/hypha/apply/projects/migrations/0037_add_project_invoicing.py +++ b/hypha/apply/projects/migrations/0037_add_project_invoicing.py @@ -6,7 +6,7 @@ import django.core.validators from django.db import migrations, models import django.db.models.deletion -import hypha.apply.projects.models.payment +import hypha.apply.projects.models.invoice class Migration(migrations.Migration): @@ -56,7 +56,7 @@ class Migration(migrations.Migration): "document", models.FileField( storage=django.core.files.storage.FileSystemStorage(), - upload_to=hypha.apply.projects.models.payment.invoice_path, + upload_to=hypha.apply.projects.models.invoice.invoice_path, ), ), ("requested_at", models.DateTimeField(auto_now_add=True)), diff --git a/hypha/apply/projects/migrations/0103_alter_contract_options_and_more.py b/hypha/apply/projects/migrations/0103_alter_contract_options_and_more.py index f6b34c6750..294698e793 100644 --- a/hypha/apply/projects/migrations/0103_alter_contract_options_and_more.py +++ b/hypha/apply/projects/migrations/0103_alter_contract_options_and_more.py @@ -3,7 +3,7 @@ import datetime import django.core.files.storage import django.core.validators -import hypha.apply.projects.models.payment +import hypha.apply.projects.models.invoice import hypha.apply.projects.models.project from decimal import Decimal from django.db import migrations, models @@ -235,7 +235,7 @@ class Migration(migrations.Migration): name="document", field=models.FileField( storage=django.core.files.storage.FileSystemStorage(), - upload_to=hypha.apply.projects.models.payment.invoice_path, + upload_to=hypha.apply.projects.models.invoice.invoice_path, verbose_name="document", ), ), diff --git a/hypha/apply/projects/models/__init__.py b/hypha/apply/projects/models/__init__.py index 1b258a2d9d..f998756da5 100644 --- a/hypha/apply/projects/models/__init__.py +++ b/hypha/apply/projects/models/__init__.py @@ -1,4 +1,4 @@ -from .payment import Invoice, InvoiceExportManager, InvoiceTag, SupportingDocument +from .invoice import Invoice, InvoiceExportManager, InvoiceTag, SupportingDocument from .project import ( Contract, ContractDocumentCategory, diff --git a/hypha/apply/projects/models/payment.py b/hypha/apply/projects/models/invoice.py similarity index 97% rename from hypha/apply/projects/models/payment.py rename to hypha/apply/projects/models/invoice.py index c809df3880..391a73b578 100644 --- a/hypha/apply/projects/models/payment.py +++ b/hypha/apply/projects/models/invoice.py @@ -301,10 +301,7 @@ def value(self): return self.paid_value def get_absolute_url(self): - return reverse( - "apply:projects:invoice-detail", - kwargs={"pk": self.project.pk, "invoice_pk": self.pk}, - ) + return reverse("apply:projects:invoice-detail", kwargs={"pk": self.pk}) @property def filename(self): @@ -337,11 +334,7 @@ def filename(self): def get_absolute_url(self): return reverse( "apply:projects:invoice-supporting-document", - kwargs={ - "pk": self.invoice.project.pk, - "invoice_pk": self.invoice.pk, - "file_pk": self.pk, - }, + kwargs={"pk": self.invoice.pk, "file_pk": self.pk}, ) diff --git a/hypha/apply/projects/service_utils.py b/hypha/apply/projects/service_utils.py index 29bcddaa6c..e6ca9e89af 100644 --- a/hypha/apply/projects/service_utils.py +++ b/hypha/apply/projects/service_utils.py @@ -15,7 +15,7 @@ FINANCE_GROUP_NAME, ) -from .models.payment import ( +from .models.invoice import ( APPROVED_BY_FINANCE, APPROVED_BY_STAFF, CHANGES_REQUESTED_BY_FINANCE, diff --git a/hypha/apply/projects/tables.py b/hypha/apply/projects/tables.py index a4aabefc28..eaad7ba631 100644 --- a/hypha/apply/projects/tables.py +++ b/hypha/apply/projects/tables.py @@ -13,7 +13,7 @@ from hypha.apply.funds.tables import LabeledCheckboxColumn from hypha.core.tables import RelativeTimeColumn -from .forms.payment import get_invoice_possible_transition_for_user +from .forms.invoice import get_invoice_possible_transition_for_user from .models import Invoice, PAFApprovals, Project from .utils import get_project_title diff --git a/hypha/apply/projects/tasks.py b/hypha/apply/projects/tasks.py index 78762693ff..e33b723963 100644 --- a/hypha/apply/projects/tasks.py +++ b/hypha/apply/projects/tasks.py @@ -3,7 +3,7 @@ from celery import shared_task from django.conf import settings -from hypha.apply.projects.models.payment import InvoiceExportManager +from hypha.apply.projects.models.invoice import InvoiceExportManager from hypha.apply.projects.utils import export_invoices_to_csv from hypha.apply.todo.options import ( DOWNLOAD_INVOICES_EXPORT, @@ -21,7 +21,7 @@ def generate_invoice_csv(qs_ids: List[int], request_user_id: int) -> None: adds a download task to the user's `My Tasks` when completed. """ try: - from hypha.apply.projects.models.payment import Invoice + from hypha.apply.projects.models.invoice import Invoice qs = ( Invoice.objects.filter(id__in=qs_ids) diff --git a/hypha/apply/projects/templates/application_projects/invoice_detail.html b/hypha/apply/projects/templates/application_projects/invoice_detail.html index daed3300d2..50e8ae9b2d 100644 --- a/hypha/apply/projects/templates/application_projects/invoice_detail.html +++ b/hypha/apply/projects/templates/application_projects/invoice_detail.html @@ -51,7 +51,7 @@
@@ -59,7 +59,7 @@
{% trans "Supporting Documents" %}