diff --git a/CHANGELOG.md b/CHANGELOG.md index db145fe..6d68ee8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,5 +5,7 @@ v1.0 Remove retry logic around reissue pickups 1.1.1 -Change incremental sync to use GetModifiedOrders API call -Remove retry logic around reissue pickups +Change incremental sync to use GetModifiedOrders API call + +1.1.2 +Add 30 day window from expiration for doing renewals instead of reissues diff --git a/README.md b/README.md index d58ec3f..d0ce3a5 100644 --- a/README.md +++ b/README.md @@ -133,12 +133,15 @@ This extension uses the contact information of the GCC Domain point of contact f GlobalSign supports specific combinations of SAN types with certain GlobalSign products. For example, a Private IP can only be used as a SAN with a `PV_INTRA` Certificate. Please refer to the GlobalSign documentation for more information on SAN usage: [GlobalSign MSSL API User Guide (Section 2.2.5)](https://www.globalsign.com/en/repository/globalsign-mssl-api-user-guide.pdf) -## Enrollment Fields +## Enrollment ### Required Enrollment Fields The following fields are required for enrollment on all certificate templates: - **ContactName**: Set Data Type to 'string' when creating the field. The name of the contact person for the certificate. This is required by the GlobalSign API. +### Renewal vs Reissue +Currently, the gateway determines whether to do a renew or reissue based on the expiration date of the certificate in question. If it is within 30 days of expiration, the gateway will do a renew; otherwise, it will do a reissue. + ### PV_INTRA Specific Enrollment Fields The following fields are available for use in the enrollment of `PV_INTRA` Certificates: - **PrivateDomain**: Set Data Type to 'string' when creating the field. Set to `true` if enrolling a certificate for a private domain (e.g., `.local`, `.lab`, etc.). diff --git a/docsource/configuration.md b/docsource/configuration.md index b6afe0d..ea208a3 100644 --- a/docsource/configuration.md +++ b/docsource/configuration.md @@ -24,12 +24,15 @@ GlobalSign supports specific combinations of SAN types with certain GlobalSign p Please refer to the GlobalSign documentation for more information on SAN usage: [GlobalSign MSSL API User Guide (Section 2.2.5)](https://www.globalsign.com/en/repository/globalsign-mssl-api-user-guide.pdf) -## Enrollment Fields +## Enrollment ### Required Enrollment Fields The following fields are required for enrollment on all certificate templates: - **ContactName**: Set Data Type to 'string' when creating the field. The name of the contact person for the certificate. This is required by the GlobalSign API. +### Renewal vs Reissue +Currently, the gateway determines whether to do a renew or reissue based on the expiration date of the certificate in question. If it is within 30 days of expiration, the gateway will do a renew; otherwise, it will do a reissue. + ### PV_INTRA Specific Enrollment Fields The following fields are available for use in the enrollment of `PV_INTRA` Certificates: - **PrivateDomain**: Set Data Type to 'string' when creating the field. Set to `true` if enrolling a certificate for a private domain (e.g., `.local`, `.lab`, etc.). diff --git a/globalsign-mssl-caplugin/GlobalSignCAPlugin.cs b/globalsign-mssl-caplugin/GlobalSignCAPlugin.cs index d6ec046..1aa848d 100644 --- a/globalsign-mssl-caplugin/GlobalSignCAPlugin.cs +++ b/globalsign-mssl-caplugin/GlobalSignCAPlugin.cs @@ -427,7 +427,7 @@ public async Task Enroll(string csr, string subject, Dictionar expirationDate = localcert.RevocationDate; } - if (expirationDate < DateTime.Now) renewal = true; + if (expirationDate.Value.AddDays(-30) < DateTime.Now) renewal = true; // 30 day renewal window if (renewal) { Logger.LogDebug(