Thoughts for future improvements

[philbucher]

• ModelPart should be iterable with auto like in Kratos => for (auto& node : model_part.Nodes()) { ... } => [ModelPart] support for range based loops #266
• remove unnecessary files from ext libs and keep only the files that are really needed (same as is done in Kratos) => remove unused pybind files #356
• add method with which cleanup (of files & comm-folders) can be triggered explicitly in case sth crashes
• missing internal updates for ModelPart
  • switch from shared_ptr to intrusive_ptr (from Kratos) => Using intrusive_ptr for Node & Element #182
  • use an unordered_map as additional data-structure to speed up the Id-based search [ModelPart] improving speed of creating entities #314
• move version-creation to CMake (like Kratos)
• Keep track of created Info in C to delete the undeleted one at the end
• Tests with complete cases with Kratos => should again serve as tutorials
• add possibility to add custom logging (and exception handling?)? (essentially pass fct pointers)
• maybe add some error handling to the file reading of vtk files. Although it should really not crash, otherwise most probably the vtk file itself is corrupted
• https://stackoverflow.com/questions/481673/make-a-copy-of-a-char => for the connection_name (otherwise we have to keep the Info coming from Connect the entire time) => using strcpy #124, didn't go in in the end
• make comment abt connection_name in C-Interface, see using strcpy #124
• check and improve the sync file (check how long it takes, and if some info should be added)
• Refactor vtu writing so that also it can be used to write a ModelPart to vtk directly for debugging purposes (maybe even with Data (like we do for vtu?))
• Make things in FileCommunication configureable (?):
  • file wait time (related: reduce wait time in FileCommunication #133)
  • file precision
• fix properly the file comm in Win => hopefully solved for good in Improve file access concurrency issues #139
• improve checks in Connect => see File comm/check version #140
• Add possibility to triangulate when having to deal with interfaces that have "strange" geometries (such as OpenFOAM with polynoms with different number of nodes)
• fix CMake warning (discuss with @pooyan-dadvand what is the best way): => [CMake] fixing some warnings #274

philipp:~/software/CoSimIO$ ./scripts/build_python.sh 
CMake Warning (dev) at CMakeLists.txt:1 (project):
  Policy CMP0048 is not set: project() command manages VERSION variables.
  Run "cmake --help-policy CMP0048" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  The following variable(s) would be set to empty:

    CMAKE_PROJECT_VERSION
    CMAKE_PROJECT_VERSION_MAJOR
    CMAKE_PROJECT_VERSION_MINOR
    CMAKE_PROJECT_VERSION_PATCH

• missing things for the documentation from Roadmap Release 2.0 #55
• fix asio include for header only version
• port codeLocation from Kratos
• FileCommunication should optionally use vtk
• Add Pyramid element types! => Adding Pyramid elements #271
• Make serializer trace type selectable

Testing

• check if works properly from different compilation units (and add tests!)
• make sure numpy is available in the CI
• Add tests for FileSerializer
• Add tests for StreamSerializer (where one writes and the other one loads form the stream, this is how it is done in the communication)
• Add missing tests for MPIDataCommunicator
• Python: Adding tests for passing CoSimIO.Vector (see [Python] adding Vector #118) by ref (in python and C++) => make sure the opaque types work
• bring back tests from removing old Import/ExportMesh interface and update C tests #138
• add linux build with Clang & Intel => overall restructure CI a bit such that it is less confusing => improving CI #166
• test for connecting multiple times
• Fixing usage across libraries / translation units #189
• CI: add one configuration with unity build

[loumalouomega]

FYI https://zeromq.org/

[philbucher]

FYI https://zeromq.org/

Thx for the suggestion, I know abt this one. It could theoretically be used instead of ASIO.

There are actually many small IPC libraries out there that one could try

However not sure how much benefit it would bring in CoSimulation, since even when using Files the transfer times are usually much smaller than the solver (with my implementations ofc :D)