Skip to content

deps: bump ThirdParty/SDL2 from e4f75ba to 96c03dc#526

Closed
dependabot[bot] wants to merge 1 commit into
Workingfrom
dependabot/submodules/ThirdParty/SDL2-96c03dc
Closed

deps: bump ThirdParty/SDL2 from e4f75ba to 96c03dc#526
dependabot[bot] wants to merge 1 commit into
Workingfrom
dependabot/submodules/ThirdParty/SDL2-96c03dc

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 1, 2026

Copy link
Copy Markdown
Contributor

Bumps ThirdParty/SDL2 from e4f75ba to 96c03dc.

Commits
  • 96c03dc Fix web joystick vibration (again)
  • dc8b189 examples: Added input/05-gamepad-rumble
  • e0eb40f Fix web joystick vibration on Safari
  • 38e7155 Sync SDL3 wiki -> header
  • 098a066 docs: Update documentation for SDL_stack_free.
  • 67e6f5b stdinc: make SDL_stack_free evaluate to ((void)(data)) when alloca is usable.
  • 189877b joystick: Fix conflicting rumble and LED on Sony PS4 gamepads
  • e1aaebf SDL_migration.cocci: Add joystick/gamepad event state functions.
  • 0cf06bf SDL_migration.cocci: add SDL_JoystickGetGUIDString -> SDL_GUIDToString.
  • dd0536b stdinc: only use _Countof for SDL_arraysize when using a C standard > C23
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ThirdParty/SDL2](https://github.com/libsdl-org/SDL) from `e4f75ba` to `96c03dc`.
- [Release notes](https://github.com/libsdl-org/SDL/releases)
- [Commits](libsdl-org/SDL@e4f75ba...96c03dc)

---
updated-dependencies:
- dependency-name: ThirdParty/SDL2
  dependency-version: 96c03dc66e89765d5f81123c2056706dd6f28ea7
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @github

dependabot Bot commented on behalf of github Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Labels

The following labels could not be found: dependencies, submodules. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

❌ CI Error Report

Failed jobs: check-format, clang-tidy, coverage, linux-asan, linux-clang-Release, linux-gcc-Debug, linux-tsan, macos-Debug-OpenGL, macos-Release-Metal, macos-Release-OpenGL, windows-vs2022-Debug
Errors: 34 | Test failures: 0 | Compiler warnings: 0

Build Errors

File Line Error Jobs
SparkEditor/Source/Core/EditorTheme.cpp 596 code should be clang-formatted [-Wclang-format-violations] check-format
SparkEditor/Source/Core/EditorFonts.cpp 56 code should be clang-formatted [-Wclang-format-violations] check-format
SparkEditor/Source/Panels/HierarchyPanel.cpp 488 code should be clang-formatted [-Wclang-format-violations] check-format
Other errors (31)
/U er /runner/work/SparkEngine/SparkEngine/SparkEngine/Source/Engine/ECS/Component /../../../Core/PlatformAudioStub .h:274:10: fatal error: 'SDL2/SDL.h' file not found [macos-Debug-OpenGL, macos-Release-Metal, macos-Release-OpenGL]
SparkEditor\Source\Panels\ProjectBrowserPanel.cpp(31,13): error C2065: 'CSIDL_PERSONAL': undeclared identifier [build\SparkEditor\SparkEditor.vcxproj] [windows-vs2022-Debug]
SparkEditor\Source\Panels\ProjectBrowserPanel.cpp(31,13): error C3861: 'SHGetFolderPathA': identifier not found [build\SparkEditor\SparkEditor.vcxproj] [windows-vs2022-Debug]
build\bin\SparkInstaller.exe : fatal error LNK1120: 13 unresolved externals [build\SparkInstaller\SparkInstaller.vcxproj] [windows-vs2022-Debug]
unresolved external symbol: __imp_strncpy referenced in function "void __cdecl ImStrncpy(char *,char const *,unsigned __int64)" (?ImStrncpy@@YAXPEAD [windows-vs2022-Debug]
unresolved external symbol: __imp__wassert [build\SparkInstaller\SparkInstaller.vcxproj] [windows-vs2022-Debug]
unresolved external symbol: __imp__wassert [build\SparkInstaller\SparkInstaller.vcxproj] [windows-vs2022-Debug]
unresolved external symbol: __imp__wassert [build\SparkInstaller\SparkInstaller.vcxproj] [windows-vs2022-Debug]
unresolved external symbol: __imp__wassert [build\SparkInstaller\SparkInstaller.vcxproj] [windows-vs2022-Debug]
unresolved external symbol: __imp__wassert [build\SparkInstaller\SparkInstaller.vcxproj] [windows-vs2022-Debug]
unresolved external symbol: __imp__wassert [build\SparkInstaller\SparkInstaller.vcxproj] [windows-vs2022-Debug]
unresolved external symbol: __imp___stdio_common_vsscanf referenced in function _vsscanf_l [build\SparkInstaller\SparkInstaller.vcxproj] [windows-vs2022-Debug]
unresolved external symbol: __imp___stdio_common_vsscanf [build\SparkInstaller\SparkInstaller.vcxproj] [windows-vs2022-Debug]
unresolved external symbol: __imp___stdio_common_vsscanf [build\SparkInstaller\SparkInstaller.vcxproj] [windows-vs2022-Debug]
unresolved external symbol: __imp_ceilf referenced in function "void __cdecl ImGui::CalcClipRectVisibleItemsY(struct ImRect const &,struct ImVec2 co [windows-vs2022-Debug]
Full error output
SparkEditor/Source/Core/EditorTheme.cpp:596:55: error: code should be clang-formatted [-Wclang-format-violations]
SparkEditor/Source/Core/EditorFonts.cpp:56:34: error: code should be clang-formatted [-Wclang-format-violations]
SparkEditor/Source/Panels/HierarchyPanel.cpp:488:59: error: code should be clang-formatted [-Wclang-format-violations]
/U er /runner/work/SparkEngine/SparkEngine/SparkEngine/Source/Engine/ECS/Component /../../../Core/PlatformAudioStub .h:274:10: fatal error: 'SDL2/SDL.h' file not found
SparkEditor\Source\Panels\ProjectBrowserPanel.cpp(31,13): error C2065: 'CSIDL_PERSONAL': undeclared identifier [build\SparkEditor\SparkEditor.vcxproj]
SparkEditor\Source\Panels\ProjectBrowserPanel.cpp(31,13): error C3861: 'SHGetFolderPathA': identifier not found [build\SparkEditor\SparkEditor.vcxproj]
build\bin\SparkInstaller.exe : fatal error LNK1120: 13 unresolved externals [build\SparkInstaller\SparkInstaller.vcxproj]
imgui.lib(imgui.obj) : error LNK2019: unresolved external symbol __imp_strncpy referenced in function "void __cdecl ImStrncpy(char *,char const *,unsigned __int64)" (?ImStrncpy@@YAXPEADPEBD_K@Z) [build\SparkInstaller\SparkInstaller.vcxproj]
imgui.lib(imgui_impl_win32.obj) : error LNK2001: unresolved external symbol __imp__wassert [build\SparkInstaller\SparkInstaller.vcxproj]
imgui.lib(imgui_tables.obj) : error LNK2001: unresolved external symbol __imp__wassert [build\SparkInstaller\SparkInstaller.vcxproj]
imgui.lib(imgui.obj) : error LNK2001: unresolved external symbol __imp__wassert [build\SparkInstaller\SparkInstaller.vcxproj]
imgui.lib(imgui_widgets.obj) : error LNK2001: unresolved external symbol __imp__wassert [build\SparkInstaller\SparkInstaller.vcxproj]
imgui.lib(imgui_draw.obj) : error LNK2001: unresolved external symbol __imp__wassert [build\SparkInstaller\SparkInstaller.vcxproj]
imgui.lib(imgui_impl_dx11.obj) : error LNK2001: unresolved external symbol __imp__wassert [build\SparkInstaller\SparkInstaller.vcxproj]
imgui.lib(imgui.obj) : error LNK2019: unresolved external symbol __imp___stdio_common_vsscanf referenced in function _vsscanf_l [build\SparkInstaller\SparkInstaller.vcxproj]
imgui.lib(imgui_widgets.obj) : error LNK2001: unresolved external symbol __imp___stdio_common_vsscanf [build\SparkInstaller\SparkInstaller.vcxproj]
imgui.lib(imgui_tables.obj) : error LNK2001: unresolved external symbol __imp___stdio_common_vsscanf [build\SparkInstaller\SparkInstaller.vcxproj]
imgui.lib(imgui.obj) : error LNK2019: unresolved external symbol __imp_ceilf referenced in function "void __cdecl ImGui::CalcClipRectVisibleItemsY(struct ImRect const &,struct ImVec2 const &,float,int *,int *)" (?CalcClipRectVisibleItemsY@ImGui@@YAXAEBUImRect@@AEBUImVec2@@MPEAH2@Z) [build\SparkInstaller\SparkInstaller.vcxproj]
imgui.lib(imgui_draw.obj) : error LNK2001: unresolved external symbol __imp_ceilf [build\SparkInstaller\SparkInstaller.vcxproj]
imgui.lib(imgui_tables.obj) : error LNK2001: unresolved external symbol __imp_ceilf [build\SparkInstaller\SparkInstaller.vcxproj]

Updated: 2026-06-01T07:28:08Z — this comment is updated in-place, not duplicated.

@dependabot @github

dependabot Bot commented on behalf of github Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #527.

@dependabot dependabot Bot closed this Jun 8, 2026
@dependabot dependabot Bot deleted the dependabot/submodules/ThirdParty/SDL2-96c03dc branch June 8, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants