Fix assay template save: correct rowid key casing and don't log expected validations

The switch to QueryUpdateService passed the update key as Map.of("rowId", templateId), but the primary key column is "rowid" and Map.of produces a case-sensitive map, so DefaultQueryUpdateService.getKeys() never found it and threw InvalidKeyException: Value for key field 'rowid' was null or not supplied!. This broke ViralLoadAssayTest. Corrected the key to "rowid" in both AssayHelper.saveTemplate and DefaultAssayParser.saveTemplate.

The broadened catch (Exception) in AssayHelper.saveTemplate was logging expected BatchValidationExceptions from validateTemplate()/insertRows() via _log.error, so normal validation failures (e.g. "Must provide at least 2 negative controls") landed in labkey-errors.log and tripped the Selenium harness's checkErrors(), failing ELISPOT_AssayTest. Let BatchValidationException propagate ahead of the generic catch in both methods so these surface as client validation errors, not server errors.

Author: labkey-martyp

laboratory/api-src/org/labkey/api/laboratory/assay/DefaultAssayParser.java

@@ -485,7 +485,11 @@ protected void saveTemplate(ViewContext ctx, int templateId, int runId) throws B
             row.put("runid", runId);
             row.put("status", "Complete");
 
-            ti.getUpdateService().updateRows(ctx.getUser(), ctx.getContainer(), Arrays.asList(row), Arrays.asList(Map.of("rowId", templateId)), null, null);
+            ti.getUpdateService().updateRows(ctx.getUser(), ctx.getContainer(), Arrays.asList(row), Arrays.asList(Map.of("rowid", templateId)), null, null);
+        }
+        catch (BatchValidationException e)
+        {
+            throw e;
         }
         catch (Exception e)
         {

laboratory/src/org/labkey/laboratory/assay/AssayHelper.java

@@ -158,10 +158,16 @@ public Map<String, Object> saveTemplate(User u, Container c, ExpProtocol protoco
             else
             {
                 row.put("rowid", templateId);
-                List<Map<String, Object>> rows = ti.getUpdateService().updateRows(u, c, Arrays.asList(row), Arrays.asList(Map.of("rowId", templateId)), null, null);
+                List<Map<String, Object>> rows = ti.getUpdateService().updateRows(u, c, Arrays.asList(row), Arrays.asList(Map.of("rowid", templateId)), null, null);
                 return rows.get(0);
             }
         }
+        catch (BatchValidationException e)
+        {
+            // Expected validation failures (e.g. from validateTemplate() or insertRows()) should propagate to the
+            // client as-is, not be logged as server errors.
+            throw e;
+        }
         catch (Exception e)
         {
             _log.error(e.getMessage(), e);