chore: use lizardbyte-common in c++#5356
Merged
Merged
Conversation
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5356 +/- ##
==========================================
- Coverage 27.53% 27.43% -0.11%
==========================================
Files 113 113
Lines 25587 25554 -33
Branches 11237 11244 +7
==========================================
- Hits 7046 7011 -35
+ Misses 15477 15346 -131
- Partials 3064 3197 +133
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 45 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
38 tasks
Wire `lizardbyte::common` into the build and replace Sunshine’s platform-specific `set_env`/`unset_env` implementations with shared helpers from `lizardbyte-common` (including Linux `append_env` usage for RADV flags). This removes duplicated environment-variable code from platform layers, drops the now-obsolete env wrapper declarations and unit tests, and updates the `third-party/lizardbyte-common` submodule to the revision that provides the shared env utilities.
Switch test infrastructure from the standalone googletest submodule to lizardbyte-common’s bundled GoogleTest and `lizardbyte::test_support`. CMake now enables common test helpers when `BUILD_TESTS` is on, avoids re-adding gtest if it already exists, and removes the `third-party/googletest` submodule. Test fixtures were updated to inherit from `BaseTest` (and `testing::WithParamInterface` for parameterized cases) to align with the shared test framework.
Update `SunshineEventListener` to inherit from `BufferedTestEventListener` and delegate event formatting to the shared base hooks (`logTestEvent`, buffered output getters/clearers). This removes duplicated per-event handling logic in `tests_events.h` while preserving Boost log buffering behavior. The `third-party/lizardbyte-common` submodule is bumped to the revision that provides the new shared listener implementation.
Update `third-party/lizardbyte-common` to commit `d219f38090db20119906c80860833592a6be669a` to pull in the latest upstream changes.
Ensure integration and unit test fixtures invoke BaseTest::SetUp() and BaseTest::TearDown() so shared test initialization/cleanup always runs. This improves test consistency and avoids missing base fixture state. Also applies minor formatting-only cleanup in Windows display_base.cpp.
Bump `third-party/lizardbyte-common` from `d219f380` to `60bf936e` to pull in the latest upstream changes.
Updates the `third-party/lizardbyte-common` submodule reference to commit `3f29834c942d71d626f2daf67323fc61426bf524` from `60bf936e134359c65c8a044369db227f976947e5`.
Replace direct `std::getenv`/custom wrappers with `lizardbyte::common::get_env` across Linux input, KWin grab, misc, and Wayland modules. This removes duplicated env parsing logic, standardizes empty/missing-variable handling, and updates Wayland display connection code to work with the new string-based env access. Co-Authored-By: Kishi <41839133+Kishi85@users.noreply.github.com>
Switch HOME handling in Linux misc config setup from std::string to fs::path and build fallback/migration paths with path joins. This makes path construction consistent and safer for both the default ~/.config/sunshine location and old-config migration checks.
Use svg icon and badges
Drops the Read the Docs badge from the README status badges and updates the `third-party/lizardbyte-common` submodule to commit `49aa8c6`.
Update `third-party/lizardbyte-common` from `49aa8c60` to `06cd442b` to pull in the latest upstream common-library changes.
ReenigneArcher
force-pushed
the
chore/use-lizardbyte-common-in-c++
branch
from
3ddbf5c to
979e1ea
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use lizardbyte-common helpers for env functions and test setup. Also updates readme heading per LizardByte/roadmap#168.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage