Skip to content

chore: Bump @metamask/permission-controller to ^13.0.0#3984

Merged
FrederikBolding merged 3 commits intomainfrom
fb/bump-permission-controller-v13
May 4, 2026
Merged

chore: Bump @metamask/permission-controller to ^13.0.0#3984
FrederikBolding merged 3 commits intomainfrom
fb/bump-permission-controller-v13

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented May 4, 2026

Bump permission-controller to the latest version and resolve most breaking changes. Dealing with the removal of PermittedHandlerExport is a larger refactor, that we will solve in follow-up PRs, thus we copy the type into snaps-rpc-methods temporarily.


Note

Medium Risk
Upgrades a core permissions dependency and adjusts middleware/type integration points; runtime behavior should be mostly unchanged but mismatches with the new permission-controller APIs could break permission enforcement or simulations.

Overview
Updates multiple packages to use @metamask/permission-controller@^13.0.0 and refreshes the lockfile accordingly.

Adapts to breaking API changes by switching snaps-simulation to the new top-level createPermissionMiddleware helper and tightening the return type of getPermissionSpecifications.

To avoid a larger refactor from the upstream removal of PermittedHandlerExport, snaps-rpc-methods temporarily vendors that type in src/types.ts and rewires permitted-method handlers to import it locally instead of from permission-controller.

Reviewed by Cursor Bugbot for commit 1775e8b. Bugbot is set up for automated code reviews on this repo. Configure here.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 4, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​metamask/​permission-controller@​13.0.0991007994100

View full report

@FrederikBolding FrederikBolding force-pushed the fb/bump-permission-controller-v13 branch from 543b3d5 to 1775e8b Compare May 4, 2026 09:31
@FrederikBolding FrederikBolding marked this pull request as ready for review May 4, 2026 09:37
@FrederikBolding FrederikBolding requested a review from a team as a code owner May 4, 2026 09:37
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.56%. Comparing base (aab4a4e) to head (1775e8b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3984   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         429      429           
  Lines       12365    12365           
  Branches     1944     1944           
=======================================
  Hits        12187    12187           
  Misses        178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue May 4, 2026
Merged via the queue into main with commit 31f2c55 May 4, 2026
131 checks passed
@FrederikBolding FrederikBolding deleted the fb/bump-permission-controller-v13 branch May 4, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants