chore: Bump @metamask/permission-controller to ^13.0.0#3984
Merged
FrederikBolding merged 3 commits intomainfrom May 4, 2026
Merged
chore: Bump @metamask/permission-controller to ^13.0.0#3984FrederikBolding merged 3 commits intomainfrom
@metamask/permission-controller to ^13.0.0#3984FrederikBolding merged 3 commits intomainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
543b3d5 to
1775e8b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3984 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 429 429
Lines 12365 12365
Branches 1944 1944
=======================================
Hits 12187 12187
Misses 178 178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
permission-controllerto the latest version and resolve most breaking changes. Dealing with the removal ofPermittedHandlerExportis a larger refactor, that we will solve in follow-up PRs, thus we copy the type intosnaps-rpc-methodstemporarily.Note
Medium Risk
Upgrades a core permissions dependency and adjusts middleware/type integration points; runtime behavior should be mostly unchanged but mismatches with the new
permission-controllerAPIs could break permission enforcement or simulations.Overview
Updates multiple packages to use
@metamask/permission-controller@^13.0.0and refreshes the lockfile accordingly.Adapts to breaking API changes by switching
snaps-simulationto the new top-levelcreatePermissionMiddlewarehelper and tightening the return type ofgetPermissionSpecifications.To avoid a larger refactor from the upstream removal of
PermittedHandlerExport,snaps-rpc-methodstemporarily vendors that type insrc/types.tsand rewires permitted-method handlers to import it locally instead of frompermission-controller.Reviewed by Cursor Bugbot for commit 1775e8b. Bugbot is set up for automated code reviews on this repo. Configure here.