Vouch request: vyncint #2366
vyncint
started this conversation in
Vouch Request
Replies: 2 comments
|
/vouch |
0 replies
|
@vyncint has been vouched by @elezar. You can now submit pull requests to OpenShell. Welcome aboard. Please read CONTRIBUTING.md before submitting. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
What do you want to work on?
I want to work on the one part of #1098 which is: rejected policy chunks do not show the guidance that was saved for them.
I read v0.0.111:
rejection_reason(PolicyChunkfield 18) is written byupdate_draft_chunk_status, round-trips throughpolicy_store.rs, and reaches the TUI inGetDraftPolicyResponse.chunks, but crateopenshell-tuinever references the field, so the reviewer's own note is dropped at the last step. The fix stays inside the TUI crate.Two items on that issue are already done: the
validation_resultbadge, and the 2-second refresh for active sandbox view.human_summaryandintent_summarydo not exist in the repo yet, so I am leaving those out. They are a proto change and need design agreement first.Why this change?
I use OpenShell daily on MacBook (Apple Silicon Chip). There is no compute driver for apple/container, so I wrote and maintain an out-of-tree one which is the shape #1887 concluded was right. That means I approve and reject policy chunks in the TUI a lot, and I keep rejecting a chunk and then, minutes later, not remembering why. The reason is already stored.
On the Rust side, I am an active contributor to NVlabs/cuda-oxide and I also made termlens which is a test harness for ratatui TUIs. So I can verify a rendering change rather than just screenshot it.
Checklist
All reactions