Skip to content

[19.0][MIG] tracking_manager_domain: Migrate to 19.0#3600

Merged
OCA-git-bot merged 7 commits into
OCA:19.0from
c4a8-odoo:copilot/migrate-tracking-manager-domain-18-to-19
May 29, 2026
Merged

[19.0][MIG] tracking_manager_domain: Migrate to 19.0#3600
OCA-git-bot merged 7 commits into
OCA:19.0from
c4a8-odoo:copilot/migrate-tracking-manager-domain-18-to-19

Conversation

@CRogos

@CRogos CRogos commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@OCA-git-bot OCA-git-bot added series:19.0 mod:tracking_manager_domain Module tracking_manager_domain labels Apr 16, 2026
MohamedOsman7
MohamedOsman7 approved these changes May 18, 2026
View reviewed changes

@MohamedOsman7 MohamedOsman7 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MohamedOsman7

MohamedOsman7 commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

@CRogos i am just wondering why the dependency tests are failing, even though you linked the dependency PR in test-requirements.txt?

@CRogos

CRogos commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

Because this tests checks the existence of this file: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@CRogos

CRogos commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@NICO-SOLUTIONS could you review?

@NICO-SOLUTIONS

NICO-SOLUTIONS commented May 20, 2026

Copy link
Copy Markdown
Member

@NICO-SOLUTIONS could you review?

@CRogos
Sure — just a quick question: why did you remove the test?

@CRogos CRogos force-pushed the copilot/migrate-tracking-manager-domain-18-to-19 branch 2 times, most recently from 391bf69 to 1ebc27c Compare May 20, 2026 15:32
@CRogos

CRogos commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

@CRogos Sure — just a quick question: why did you remove the test?

Good question.. probably because the patched method was removed from tracking_manager... I've readded the test and patched the mail module.

@NICO-SOLUTIONS NICO-SOLUTIONS mentioned this pull request May 25, 2026
Closed
1 task
NICO-SOLUTIONS
NICO-SOLUTIONS approved these changes May 25, 2026
View reviewed changes

@NICO-SOLUTIONS NICO-SOLUTIONS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CRogos
Looks good to me.
I added a PR to improve the overall test coverage.
It ensures that all code paths introduced by the related changes are properly covered, including previously missing edge cases.

@CRogos CRogos force-pushed the copilot/migrate-tracking-manager-domain-18-to-19 branch from 1ebc27c to 4ec775c Compare May 26, 2026 16:11
@CRogos

CRogos commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

/ocabot migration tracking_manager_domain
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone May 29, 2026
@OCA-git-bot

OCA-git-bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-3600-by-CRogos-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request May 29, 2026
Open
43 tasks
@OCA-git-bot OCA-git-bot merged commit 6365376 into OCA:19.0 May 29, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 57df9ae. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@NICO-SOLUTIONS NICO-SOLUTIONS NICO-SOLUTIONS approved these changes

@MohamedOsman7 MohamedOsman7 MohamedOsman7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:tracking_manager_domain Module tracking_manager_domain series:19.0

Projects

None yet

Milestone

19.0

Development

Successfully merging this pull request may close these issues.

5 participants

@CRogos @MohamedOsman7 @NICO-SOLUTIONS @OCA-git-bot @mymage