olc::QuickGui::TextBox focusing issue

[docteurzoidberg]

When multiple textboxes are present in same app, focusing from one to another copy the value of last focused textbox into the next one.

Also, when console is opened, we are still able to focus textboxes underneath and it replace the console text input with focused textbox one.

(Will try to fix if I can but I prefer to post the issue for tracking, also I am maybe not skilled enough in olc::pge to fix the code myself)

[zmira]

hi!
don't know if this is still an issue for you, but the trick for the multiple textbox problem is to always try to process/update the focused textbox first.

this means that void Manager::Update(olc::PixelGameEngine* pge) needs to be adjusted in order to invoke each of the control's Update on a sorted m_vControls.

I'm not a C++ person but in C# this is an example of what could be done (I know there are better/faster/cleaner ways to do this, but this is just a Q&D example)

public void Update(PixelGameEngine pge)
{
        foreach (var control in _controls.OrderByDescending(control => control is TextBox textBox && textBox.TextEditEnabled))
        {
            control.Update(pge);
        }
    }

Since I know close to nothing of C++, the above converted by an online C#-to-C++ converter translates to something along the lines of

void Manager::Update(olc::PixelGameEngine* pge)
{
    std::sort(m_vControls.begin(), m_vControls.end(),
    [](const std::shared_ptr<BaseControl>& a, const std::shared_ptr<BaseControl>& b)
    {
        auto aTextBox = std::dynamic_pointer_cast<TextBox>(a);
        auto bTextBox = std::dynamic_pointer_cast<TextBox>(b);
        bool aEnabled = aTextBox && aTextBox->m_bTextEdit;
        bool bEnabled = bTextBox && bTextBox->m_bTextEdit;

        return aEnabled > bEnabled; // descending order
    });

    for (auto& p : m_vControls) p->Update(pge);
}

[zmira]

In regards to the focusing of textboxes, and for that matter any interaction with controls, when the console is opened you could use the IsConsoleShowing() method.

This would need to be done by updating each of the interactable controls' Update(...) method to include an additional condition to check if the console is being displayed.

For example,

	void Button::Update(olc::PixelGameEngine* pge)
	{
		if (m_state == State::Disabled || !bVisible || pge->IsConsoleShowing())
			return;
	// ...