[ModelicaSystem] add missing 'raise' keywords for exceptions (#286)

* [ModelicaSystem] add missing 'raise' keywords for exceptions

* update tests

---------

Co-authored-by: Adeel Asghar <adeel.asghar@liu.se>

Author: syntron

OMPython/ModelicaSystem.py

@@ -286,7 +286,7 @@ def _run_cmd(self, cmd: list, timeout: Optional[int] = None):
             # set the process environment from the generated .bat file in windows which should have all the dependencies
             batFilePath = pathlib.Path(self.tempdir) / f"{self.modelName}.bat"
             if not batFilePath.exists():
-                ModelicaSystemError("Batch file (*.bat) does not exist " + str(batFilePath))
+                raise ModelicaSystemError("Batch file (*.bat) does not exist " + str(batFilePath))
 
             with open(batFilePath, 'r') as file:
                 for line in file:
@@ -351,7 +351,7 @@ def requestApi(self, apiName, entity=None, properties=None):  # 2
 
     def xmlparse(self):
         if not self.xmlFile.exists():
-            ModelicaSystemError(f"XML file not generated: {self.xmlFile}")
+            raise ModelicaSystemError(f"XML file not generated: {self.xmlFile}")
 
         tree = ET.parse(self.xmlFile)
         rootCQ = tree.getroot()
@@ -907,11 +907,11 @@ def checkValidInputs(self, name):
             if isinstance(l, tuple):
                 # if l[0] < float(self.simValuesList[0]):
                 if l[0] < float(self.simulateOptions["startTime"]):
-                    ModelicaSystemError('Input time value is less than simulation startTime')
+                    raise ModelicaSystemError('Input time value is less than simulation startTime')
                 if len(l) != 2:
-                    ModelicaSystemError(f'Value for {l} is in incorrect format!')
+                    raise ModelicaSystemError(f'Value for {l} is in incorrect format!')
             else:
-                ModelicaSystemError('Error!!! Value must be in tuple format')
+                raise ModelicaSystemError('Error!!! Value must be in tuple format')
 
     def createCSVData(self) -> pathlib.Path:
         start_time: float = float(self.simulateOptions["startTime"])

tests/test_ModelicaSystem.py

@@ -360,13 +360,13 @@ def test_simulate_inputs(self):
         assert np.isclose(y[-1], 1.0)
 
         # let's try some edge cases
-        mod.setInputs("u1=[(-0.5, 0.0), (1.0, 1)]")
         # unmatched startTime
         with self.assertRaises(OMPython.ModelicaSystemError):
+            mod.setInputs("u1=[(-0.5, 0.0), (1.0, 1)]")
             mod.simulate()
         # unmatched stopTime
-        mod.setInputs("u1=[(0.0, 0.0), (0.5, 1)]")
         with self.assertRaises(OMPython.ModelicaSystemError):
+            mod.setInputs("u1=[(0.0, 0.0), (0.5, 1)]")
             mod.simulate()
 
         # Let's use both inputs, but each one with different number of of