Stop test command shims leaking into the global scope

Remove-Item does not accept a 'global:' scope qualifier in a provider path,
so the AfterAll cleanup silently failed and left the Find-PSResource,
Publish-PSResource, Resolve-PSModuleDependency, gh, and git shims in the
global scope. Later test files then resolved the shims instead of the real
commands, which failed Get-NextPrereleaseNumber with 'A parameter cannot be
found that matches parameter name Prerelease'.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: 2 people

.github/actions/Publish-PSModule/tests/Publish-PSModule.Recovery.Tests.ps1

@@ -29,9 +29,11 @@ AfterAll {
     foreach ($name in $script:environmentVariableNames) {
         [System.Environment]::SetEnvironmentVariable($name, $script:originalEnvironment[$name])
     }
-    Remove-Item -Path function:global:Find-PSResource -ErrorAction SilentlyContinue
-    Remove-Item -Path function:global:Publish-PSResource -ErrorAction SilentlyContinue
-    Remove-Item -Path function:global:Resolve-PSModuleDependency -ErrorAction SilentlyContinue
+    # The 'global:' scope qualifier is not a valid provider path, so it must be omitted here.
+    # Otherwise the shims leak into the global scope and shadow the real cmdlets in later test files.
+    Remove-Item -Path 'Function:\Find-PSResource' -ErrorAction SilentlyContinue
+    Remove-Item -Path 'Function:\Publish-PSResource' -ErrorAction SilentlyContinue
+    Remove-Item -Path 'Function:\Resolve-PSModuleDependency' -ErrorAction SilentlyContinue
 }
 
 Describe 'Publish-PSModule recovery' {

.github/actions/Release-PSModule/tests/Release-PSModule.WhatIf.Tests.ps1

@@ -35,8 +35,10 @@ AfterAll {
     foreach ($name in $script:environmentVariableNames) {
         [System.Environment]::SetEnvironmentVariable($name, $script:originalEnvironment[$name])
     }
-    Remove-Item -Path function:global:gh -ErrorAction SilentlyContinue
-    Remove-Item -Path function:global:git -ErrorAction SilentlyContinue
+    # The 'global:' scope qualifier is not a valid provider path, so it must be omitted here.
+    # Otherwise the shims leak into the global scope and shadow the real commands in later test files.
+    Remove-Item -Path 'Function:\gh' -ErrorAction SilentlyContinue
+    Remove-Item -Path 'Function:\git' -ErrorAction SilentlyContinue
 }
 
 Describe 'Release-PSModule WhatIf' {