BridgeJS: Test generic exports and callback lifetimes

Author: krodak

Plugins/BridgeJS/Tests/BridgeJSToolTests/BridgeJSLinkTests.swift

@@ -79,6 +79,7 @@ import Testing
     }
 
     @Test(arguments: [
+        "GenericInitializers.swift",
         "Namespaces.swift",
         "StaticFunctions.swift",
         "StaticProperties.swift",
@@ -157,6 +158,105 @@ import Testing
         return try bridgeJSLink.link().0
     }
 
+    @Test
+    func genericRuntimeIsGatedToGenericBuilds() throws {
+        let genericJS = try linkedJS(forFixture: "GenericImports.swift")
+        #expect(genericJS.contains("__bjs_codecByTypeId"))
+        #expect(genericJS.contains("function __bjs_codecForTypeId(typeId) {"))
+        #expect(genericJS.contains("bjs[\"bjs_TestModule_register_type_handles\"] = function(base, count) {"))
+        #expect(genericJS.contains("instance.exports[\"bjs_TestModule_register_type_handles\"]();"))
+
+        let nonGenericJS = try linkedJS(forFixture: "SwiftStructImports.swift")
+        #expect(!nonGenericJS.contains("__bjs_codecByTypeId"))
+        #expect(!nonGenericJS.contains("__bjs_codecForTypeId"))
+        #expect(nonGenericJS.contains("bjs[\"bjs_core_register_type_handles\"] = function() {};"))
+        #expect(nonGenericJS.contains("bjs[\"bjs_TestModule_register_type_handles\"] = function() {};"))
+        #expect(!nonGenericJS.contains("instance.exports[\"bjs_TestModule_register_type_handles\"]();"))
+    }
+
+    @Test(arguments: [
+        "@JS func identity<T: BridgedSwiftGenericBridgeable>(_ value: T) -> T { value }",
+        "@JS class Box { @JS func identity<T: BridgedSwiftGenericBridgeable>(_ value: T) -> T { value } }",
+        "@JS class Box { @JS init<T: BridgedSwiftGenericBridgeable>(_ value: T) {} }",
+    ])
+    func genericExportsEnableCoreTypeRegistration(source: String) throws {
+        let js = try linkSource(source).js
+        #expect(js.contains("__bjs_typeIdByToken.set(tokens[i], typeIds[i]);"))
+        #expect(js.contains("instance.exports[\"bjs_core_register_type_handles\"]();"))
+    }
+
+    @Test
+    func sameTypeNameAcrossModulesLinksWithHandleIdentity() throws {
+        func makeSkeleton(moduleName: String, source: String) throws -> BridgeJSSkeleton {
+            let swiftAPI = SwiftToSkeleton(
+                progress: .silent,
+                moduleName: moduleName,
+                exposeToGlobal: false,
+                externalModuleIndex: .empty
+            )
+            swiftAPI.addSourceFile(Parser.parse(source: source), inputFilePath: "\(moduleName).swift")
+            return try swiftAPI.finalize()
+        }
+        let structSource = """
+            @JS public struct Point {
+                public var x: Int
+                @JS public init(x: Int) { self.x = x }
+            }
+            """
+        let first = try makeSkeleton(
+            moduleName: "FirstModule",
+            source: structSource + """
+
+                @JSFunction func identity<T: BridgedSwiftGenericBridgeable>(_ value: T) throws(JSException) -> T
+                """
+        )
+        let second = try makeSkeleton(moduleName: "SecondModule", source: structSource)
+        let bridgeJSLink = BridgeJSLink(skeletons: [first, second])
+        let js = try bridgeJSLink.link().outputJs
+        #expect(js.contains("bjs[\"bjs_FirstModule_register_type_handles\"] = function(base, count) {"))
+        #expect(js.contains("bjs[\"bjs_SecondModule_register_type_handles\"] = function(base, count) {"))
+    }
+
+    @Test(arguments: [false, true])
+    func sameTypeNameAcrossModulesFailsWithGenericExports(distinctNamespaces: Bool) throws {
+        func makeSkeleton(moduleName: String, source: String) throws -> BridgeJSSkeleton {
+            let swiftAPI = SwiftToSkeleton(
+                progress: .silent,
+                moduleName: moduleName,
+                exposeToGlobal: false,
+                externalModuleIndex: .empty
+            )
+            swiftAPI.addSourceFile(Parser.parse(source: source), inputFilePath: "\(moduleName).swift")
+            return try swiftAPI.finalize()
+        }
+        let structSource = """
+            @JS public struct Point {
+                public var x: Int
+                @JS public init(x: Int) { self.x = x }
+            }
+            """
+        let first = try makeSkeleton(
+            moduleName: "FirstModule",
+            source: structSource + """
+
+                @JS public func identity<T: BridgedSwiftGenericBridgeable>(_ value: T) -> T { value }
+                """
+        )
+        let second = try makeSkeleton(
+            moduleName: "SecondModule",
+            source: distinctNamespaces
+                ? structSource.replacingOccurrences(
+                    of: "@JS public struct",
+                    with: "@JS(namespace: \"Other\") public struct"
+                )
+                : structSource
+        )
+        let bridgeJSLink = BridgeJSLink(skeletons: [first, second])
+        #expect(throws: BridgeJSLinkError.self) {
+            _ = try bridgeJSLink.link()
+        }
+    }
+
     @Test
     func perClassIdentityModeFromAnnotation() throws {
         let url = Self.inputsDirectory.appendingPathComponent("IdentityModeClass.swift")

Plugins/BridgeJS/Tests/BridgeJSToolTests/CodegenTestSupport.swift

@@ -22,6 +22,31 @@ func makeSkeleton(
     return try swiftAPI.finalize()
 }
 
+func renderExportGlue(
+    _ source: String,
+    moduleName: String = "TestModule"
+) throws -> String {
+    let skeleton = try makeSkeleton(source, moduleName: moduleName)
+    let exported = try #require(skeleton.exported)
+    let exportSwift = ExportSwift(
+        progress: .silent,
+        moduleName: skeleton.moduleName,
+        skeleton: exported
+    )
+    return try #require(try exportSwift.finalize())
+}
+
+func linkSource(_ source: String, moduleName: String = "TestModule") throws -> (js: String, dts: String) {
+    let skeleton = try makeSkeleton(source, moduleName: moduleName)
+    var bridgeJSLink = BridgeJSLink()
+    let encoder = JSONEncoder()
+    encoder.outputFormatting = [.prettyPrinted, .sortedKeys]
+    let unifiedData = try encoder.encode(skeleton)
+    try bridgeJSLink.addSkeletonFile(data: unifiedData)
+    let result = try bridgeJSLink.link()
+    return (result.outputJs, result.outputDts)
+}
+
 func expectDiagnostic(
     source: String,
     moduleName: String = "App",

Plugins/BridgeJS/Tests/BridgeJSToolTests/DiagnosticsTests.swift

@@ -833,6 +833,16 @@ import Testing
         )
     }
 
+    @Test func constraintOnlyJSProtocolConformer() throws {
+        _ = try makeSkeleton(
+            """
+            @JS protocol GraphNode { var id: String { get } }
+            @JS struct Building: GraphNode { var id: String }
+            @JS func store<T: BridgedSwiftGenericBridgeable & GraphNode>(_ node: T) -> T { node }
+            """
+        )
+    }
+
     @Test func protocolRefinementIsNotAConcreteConformance() throws {
         _ = try makeSkeleton(
             """