Skip to content

Question on hard-coding bags_checked to 0 during rebooking #202

Description

@stevehuang52

In https://github.com/ServiceNow/eva/blob/2.1.0/src/eva/assistant/tools/airline_tools.py#L554, the bags_checked is hardcoded as 0 when rebooking flights. However, in general it seems okay to assume that the number of checked bags is directly carried over from the old flight to the new flight.

Although there's a add_baggage_allowance tool, the tool description does not explicitly explain when to call it.

Although policy says "After rebooking, always ensure seat assignments, baggage, and meal requests are moved to the new flight”, it is still not a clear guidance to use add_baggage_allowance. Since the response of rebook_flight https://github.com/ServiceNow/eva/blob/2.1.0/src/eva/assistant/tools/airline_tools.py#L607 doesn't explicitly contain the bags_checked info, it seems to add more unnecessary difficulty to the agent.

Could you please explain if the hard-coded 0 is intended or a mistake?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions