Skip to content

chore: Add PR creation guidelines to AGENTS.md#698

Open
ValerianRey wants to merge 5 commits into
mainfrom
worktree-improve-claude-md
Open

chore: Add PR creation guidelines to AGENTS.md#698
ValerianRey wants to merge 5 commits into
mainfrom
worktree-improve-claude-md

Conversation

@ValerianRey
Copy link
Copy Markdown
Contributor

@ValerianRey ValerianRey commented May 20, 2026

Almost everytime, claude code creates PRs with too long title and it never adds the correct labels. This should fix both issues (and should also be beneficial for other agents than claude code).

Summary

  • Documents how to set labels (cc: <type>, package: <scope>, breaking-change) when creating a PR
  • Explains that the CI prepends the conventional commit type to the title based on the cc: label
  • Adds the 72-character title length constraint (accounting for the type prefix and PR number appended on merge)

🤖 Generated with Claude Code

@ValerianRey ValerianRey requested a review from a team as a code owner May 20, 2026 23:23
@ValerianRey ValerianRey added the cc: chore Conventional commit type for changes to some configuration files of the project. label May 20, 2026
@github-actions github-actions Bot changed the title Add PR creation guidelines to AGENTS.md chore: Add PR creation guidelines to AGENTS.md May 20, 2026
@ValerianRey ValerianRey requested a review from PierreQuinton May 21, 2026 00:28
Copy link
Copy Markdown
Contributor

@PierreQuinton PierreQuinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add to make the PR text short and efficient? Long and inefficient description makes me lose a lot of time. Also I'm not convinced I'm for using this, I think it goes too much in the direction of mental charge for the reviewer (this is true of all this heavy agent usage in general, if the contributor is not careful anymore then the reviewers have to be). And lastly I think it prevents contributors from learning the framework. I think we need to be careful with all that.

@ValerianRey
Copy link
Copy Markdown
Contributor Author

Can you add to make the PR text short and efficient?

Yes, good idea.

Long and inefficient description makes me lose a lot of time.

Yeah, there's often a lot of context between each PR (e.g. the PR where I removed CUBLAS_WORKSPACE_CONFIG environment variable (#697) had several intricated reasons). I think it's good to explain everything in details. But I agree that the LLM often almost doubles the required size by not being efficient.

Also I'm not convinced I'm for using this, I think it goes too much in the direction of mental charge for the reviewer (this is true of all this heavy agent usage in general, if the contributor is not careful anymore then the reviewers have to be). And lastly I think it prevents contributors from learning the framework. I think we need to be careful with all that.

I think people are gonna use agents regardless. The productivity gain is just too big, especially for newcomers. I agree that this comes at the cost of extra reviewer work, but because of the increased number of PRs, not because of the quality of the work of agents. I think newcomers tend to work do better work with agents. And I also agree that this prevents them from really learning the codebase, but it's a tradeoff. Without agents, people wouldn't even try to understand the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: chore Conventional commit type for changes to some configuration files of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants