ParticleUplinkCannon double-click fast drive timing changes with framerate

[bobtista]

Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

The double-click detection for fast drive mode in ParticleUplinkCannonUpdate compares frame counts to milliseconds, causing inconsistent behavior at different frame rates and logic time scales.

The code compares frame number differences to a millisecond delay value:
if( m_lastDrivingClickFrame - m_2ndLastDrivingClickFrame < data->m_doubleClickToFastDriveDelay )- m_lastDrivingClickFrame stores frame numbers (TheGameLogic->getFrame())

• m_doubleClickToFastDriveDelay is in milliseconds (500ms default, parsed via parseDurationUnsignedInt)

Reproduction Steps

1. Use Particle Uplink Cannon
2. Try double-clicking to activate fast drive mode at different frame rates and logic time scales

[Caball009]

Has this issue come up from GeneralsOnline? I'd assume they'd notice this bug at 60 logic frames.

[dmgreeny]

When I play USA and use the Canon, I always click as fast as I can to make the laser move faster in a desirable direction. This is a known game mechanic, and it may concern balance changes, because of small area of effect compared to SCUD and Nuke you can move the laser faster if you're manually controlling it. I suggest we ask the community what they think about this mechanic before putting it to rest.

[Stubbjax]

I suggest we ask the community what they think about this mechanic before putting it to rest.

Nothing is being put to rest.

[Caball009]

it may concern balance changes

The proposed change does not intend to alter the default behavior.

[dmgreeny]

Thanks for clarification