fix(persistence): fail fast when the shared migration ledger diverges - #16
Conversation
yordis
commented
Aug 17, 2026
- Sharing one T3 home across branches is normal in this fork, but the migrator decides what to run purely by id and never compares names, so a database migrated by a branch with different numbering makes this build silently skip migrations while the ledger still reads as fully migrated.
- The consequence surfaced far away from its cause: the schema looked current, then an unrelated read-model query failed and the desktop backend went into a restart loop, which is an expensive way to learn that the home directory belongs to another branch.
- Failing at startup with the list of migrations that would be skipped points at the actual decision the developer has to make, which is where the home directory should live.
- The check lives in the fork's own migration chain so the shared migration files stay byte-identical to upstream.
PR SummaryMedium Risk Overview SQLite persistence setup now calls this check on every open. Tests cover fresh/partial/future ids, divergent branch chains, missing ledger rows, and legacy realign paths. Fork docs add 0006 (separate fork ledger + startup check) and index it in the fork README. Reviewed by Cursor Bugbot for commit 8814a80. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Warning Review limit reached
Next review available in: 40 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
76f3e7e to
8814a80
Compare