Skip to content

docs(agents): record our fork's PR conventions - #19

Merged
yordis merged 3 commits into
mainfrom
yordis/docs-drop-pr-harness-footer
Aug 17, 2026
Merged

docs(agents): record our fork's PR conventions#19
yordis merged 3 commits into
mainfrom
yordis/docs-drop-pr-harness-footer

Conversation

@yordis

@yordis yordis commented Aug 17, 2026

Copy link
Copy Markdown
Member

Two of upstream's PR conventions do not hold here, and leaving them unwritten means every agent rediscovers them by getting it wrong first.

  • PR bodies in this fork should not carry authorship metadata about who or what produced the change; that is a decision for the repository owner to make per PR, not a blanket convention.
  • Work in this fork stays in this fork by default. Opening against pingdotgg/t3code publishes a change to the upstream project that was never meant to go there, and that is not reversible by closing the PR.

@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation-only change to PR writing conventions with no runtime or product behavior impact.

Overview
Updates contributor guidance in AGENTS.md so PR bodies only need a short problem statement and fix description.

The Pull requests section no longer tells authors to end the body with model and harness authorship metadata.

Reviewed by Cursor Bugbot for commit b96393a. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS labels Aug 17, 2026
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e966b5a7-15a7-4ecf-ba30-4bae639d77a0

📥 Commits

Reviewing files that changed from the base of the PR and between ffa3ef0 and 6c2c929.

📒 Files selected for processing (3)
  • AGENTS.md
  • docs/fork/0010-fork-pull-request-conventions.md
  • docs/fork/README.md

Walkthrough

The pull request updates fork-local pull request instructions, documents the conventions, and adds the convention to the fork divergence ledger.

Changes

Fork pull request conventions

Layer / File(s) Summary
Document pull request conventions
AGENTS.md, docs/fork/0010-fork-pull-request-conventions.md, docs/fork/README.md
Pull requests now default to TrogonStack/t3code. The documentation records body and attribution rules and adds the active convention to the ledger.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A rabbit checks the pull request trail,
Fork-first rules now mark the rail.
The body stays clear and light,
The ledger keeps the record right,
And syncs preserve the sign.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/docs-drop-pr-harness-footer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis yordis changed the title docs(agents): drop the authorship footer from PR bodies docs(agents): record our fork's PR conventions Aug 17, 2026
@yordis

yordis commented Aug 17, 2026

Copy link
Copy Markdown
Member Author
Screenshot 2026-08-17 at 9 39 14 AM

yordis added 3 commits August 17, 2026 13:33
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/docs-drop-pr-harness-footer branch from c7dee21 to 6c2c929 Compare August 17, 2026 17:33
@yordis
yordis merged commit 901d696 into main Aug 17, 2026
6 of 11 checks passed
@github-actions github-actions Bot added size:M and removed size:XS labels Aug 17, 2026
@yordis
yordis deleted the yordis/docs-drop-pr-harness-footer branch August 17, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant