From f27a8037c4a767d992158f1b592c03d511ba842f Mon Sep 17 00:00:00 2001 From: Vickydew1 Date: Wed, 17 Dec 2025 11:54:47 +0530 Subject: [PATCH 1/2] Fixed publicNetworkAccess issue --- .../virtualmachines/vmDiskPublicAccess.js | 27 ++++++++++--------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/plugins/azure/virtualmachines/vmDiskPublicAccess.js b/plugins/azure/virtualmachines/vmDiskPublicAccess.js index 9216c3a65a..7476370ea3 100644 --- a/plugins/azure/virtualmachines/vmDiskPublicAccess.js +++ b/plugins/azure/virtualmachines/vmDiskPublicAccess.js @@ -35,21 +35,22 @@ module.exports = { } for (let disk of disks.data) { if (!disk.id) continue; - - if (disk.networkAccessPolicy) { - if (disk.networkAccessPolicy.toLowerCase() === 'allowall') { - helpers.addResult(results, 2, 'Disk is publicly accessible', location, disk.id); - - } else if (disk.networkAccessPolicy.toLowerCase() === 'allowprivate') { - helpers.addResult(results, 0, 'Disk is not publicly accessible', location, disk.id); - - } else { - helpers.addResult(results, 0, 'Disk is not publicly or privately accessible', location, disk.id); - + + if (disk.publicNetworkAccess && disk.publicNetworkAccess.toLowerCase() === 'enabled') { + if (disk.networkAccessPolicy) { + if (disk.networkAccessPolicy.toLowerCase() === 'allowall') { + helpers.addResult(results, 2, 'Disk is publicly accessible', location, disk.id); + + } else if (disk.networkAccessPolicy.toLowerCase() === 'allowprivate') { + helpers.addResult(results, 0, 'Disk is not publicly accessible', location, disk.id); + + } else { + helpers.addResult(results, 0, 'Disk is not publicly or privately accessible', location, disk.id); + } } + } else { + helpers.addResult(results, 0, 'Public disk access is disabled', location, disk.id); } - - } rcb(); }, function() { From 7ac68996a9f48df5bdd30b60d5b47f509f870a82 Mon Sep 17 00:00:00 2001 From: Vickydew1 Date: Wed, 17 Dec 2025 16:40:34 +0530 Subject: [PATCH 2/2] Fix VM Disk Public Access check to handle missing publicNetworkAccess --- plugins/azure/virtualmachines/vmDiskPublicAccess.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/azure/virtualmachines/vmDiskPublicAccess.js b/plugins/azure/virtualmachines/vmDiskPublicAccess.js index 7476370ea3..d8bb53e40f 100644 --- a/plugins/azure/virtualmachines/vmDiskPublicAccess.js +++ b/plugins/azure/virtualmachines/vmDiskPublicAccess.js @@ -36,7 +36,7 @@ module.exports = { for (let disk of disks.data) { if (!disk.id) continue; - if (disk.publicNetworkAccess && disk.publicNetworkAccess.toLowerCase() === 'enabled') { + if (!disk.publicNetworkAccess || disk.publicNetworkAccess.toLowerCase() === 'enabled') { if (disk.networkAccessPolicy) { if (disk.networkAccessPolicy.toLowerCase() === 'allowall') { helpers.addResult(results, 2, 'Disk is publicly accessible', location, disk.id);