test(@angular/build): add E2E test for Vitest browser mode with coverage#33058
Conversation
clydin
force-pushed
the
test/vitest-browser-coverage
branch
4 times, most recently
from
7dd4c17 to
0effc83
Compare
This test ensures that stack traces map correctly to source files and that coverage reports are generated when running Vitest in browser mode with coverage enabled. This provides validation for the current implementation and will help verify future refactors removing the source-map-support dependency.
clydin
force-pushed
the
test/vitest-browser-coverage
branch
2 times, most recently
from
0005549 to
c5e3213
Compare
clydin
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the browser source map support plugin and its associated logic from the Vitest builder configuration, while also updating the sourcemap adjustment logic. Additionally, a new E2E test has been added to verify browser coverage. I have no feedback to provide on the code changes themselves, but please address the versioning issue identified in the E2E test file.
alan-agius4
added
action: merge
clydin
force-pushed
the
test/vitest-browser-coverage
branch
from
c5e3213 to
170f400
Compare
This change removes the injection of `source-map-support` in Vitest browser tests and enables sourcemap rebasing for coverage runs as well. This allows Vitest's native remapper to handle stack traces and coverage correctly without needing the external polyfill in the browser. The E2E tests have been verified to pass with these changes. The unused `createSourcemapSupportPlugin` function has also been removed.
clydin
force-pushed
the
test/vitest-browser-coverage
branch
from
170f400 to
890ec4c
Compare
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
This test ensures that stack traces map correctly to source files and that coverage reports are generated when running Vitest in browser mode with coverage enabled. This provides validation for the current implementation and will help verify future refactors removing the source-map-support dependency.