Add tests for filter() and arrange() with aggregation expressions

Author: HyukjinKwon

r/R/dplyr-arrange.R

@@ -46,7 +46,6 @@ arrange.arrow_dplyr_query <- function(.data, ..., .by_group = FALSE) {
         # dplyr lets you arrange on e.g. x < mean(x), but we haven't implemented it.
         # But we could, the same way it works in mutate() via join, if someone asks.
         # Until then, just error.
-        # TODO: add a test for this
         arrow_not_supported(
           .actual_msg = "Expression not supported in arrange() in Arrow",
           call = expr

r/R/dplyr-filter.R

@@ -42,7 +42,6 @@ filter.arrow_dplyr_query <- function(.data, ..., .by = NULL, .preserve = FALSE)
         # dplyr lets you filter on e.g. x < mean(x), but we haven't implemented it.
         # But we could, the same way it works in mutate() via join, if someone asks.
         # Until then, just error.
-        # TODO: add a test for this
         arrow_not_supported(
           .actual_msg = "Expression not supported in filter() in Arrow",
           call = expr

r/tests/testthat/test-dplyr-arrange.R

@@ -245,3 +245,11 @@ test_that("Can use across() within arrange()", {
     example_data
   )
 })
+
+test_that("arrange() with aggregation expressions errors", {
+  tab <- arrow_table(tbl)
+  expect_error(
+    tab |> arrange(int < mean(int)),
+    "not supported in arrange"
+  )
+})

r/tests/testthat/test-dplyr-filter.R

@@ -490,3 +490,11 @@ test_that(".by argument", {
     "Can't supply `\\.by` when `\\.data` is grouped data"
   )
 })
+
+test_that("filter() with aggregation expressions errors", {
+  tab <- arrow_table(tbl)
+  expect_error(
+    tab |> filter(int < mean(int)),
+    "not supported in filter"
+  )
+})