GH-48492: [GLib][Ruby] Add MapLookupOptions #48513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kou
approved these changes
Dec 21, 2025
Comment on lines
44
to
46
| def build_map_with_duplicate_keys | ||
| end | ||
|
|
Member
There was a problem hiding this comment.
Can we remove this?
Suggested change
| def build_map_with_duplicate_keys | |
| end |
Contributor
Author
There was a problem hiding this comment.
Some leftover from an earlier design, sorry about that.
stenlarsson
force-pushed
the
glib-map-lookup-options
branch
from
4986d0d to
18aebf4
Compare
github-actions
bot
added
awaiting committer review
Jonahkel
pushed a commit
to Jonahkel/arrow
that referenced
this pull request
Dec 22, 2025
### Rationale for this change The `MapLookupOptions` class is not available in GLib/Ruby, and it is used together with the `map_lookup` compute function. ### What changes are included in this PR? This adds the `MapLookupOptions` class to GLib. ### Are these changes tested? Yes, with Ruby unit tests. ### Are there any user-facing changes? Yes, a new class. * GitHub Issue: apache#48492 Authored-by: Sten Larsson <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 5fbefae. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
MapLookupOptionsclass is not available in GLib/Ruby, and it is used together with themap_lookupcompute function.What changes are included in this PR?
This adds the
MapLookupOptionsclass to GLib.Are these changes tested?
Yes, with Ruby unit tests.
Are there any user-facing changes?
Yes, a new class.