GH-48094: [C++] Restrict SecureString capacity tail check to Linux#49906
Merged
pitrou merged 1 commit intoapache:mainfrom May 5, 2026
Merged
GH-48094: [C++] Restrict SecureString capacity tail check to Linux#49906pitrou merged 1 commit intoapache:mainfrom
pitrou merged 1 commit intoapache:mainfrom
Conversation
|
|
Member
Author
|
cc @pitrou thanks |
Member
|
Can we condition this on MSVC rather than Linux? The test can still be used under macOS and other platforms. |
69d0341 to
1416cc9
Compare
1416cc9 to
1279689
Compare
Member
Author
|
done thanks |
Member
|
Oops, I should have changed the PR title before merging. Too late. |
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 25e4fdb. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?