Skip to content

Adding "new metadata" skill#37868

Open
stankiewicz wants to merge 2 commits intoapache:masterfrom
stankiewicz:branch_skill_metadata
Open

Adding "new metadata" skill#37868
stankiewicz wants to merge 2 commits intoapache:masterfrom
stankiewicz:branch_skill_metadata

Conversation

@stankiewicz
Copy link
Contributor

First take on adding skills.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new, detailed skill guide designed to assist developers in correctly integrating and propagating new metadata fields within Apache Beam's WindowedValue structure. The guide systematically covers all necessary modifications across the Beam ecosystem, from proto definitions to runner-specific implementations and user-facing APIs, ensuring that metadata integrity is maintained throughout complex data processing workflows.

Highlights

  • New Skill Guide Added: A new skill guide titled 'adding-new-metadata' has been introduced, providing comprehensive instructions for developers.
  • Metadata Propagation Guidance: The guide details the process of adding and correctly propagating new metadata fields within Apache Beam's WindowedValue across various system components.
  • Key Integration Points Covered: Instructions include updating proto models, WindowedValue interfaces and implementations, Dataflow's Windmill persistence, core runner components (DoFn runners, grouping, SDFs, timers), and exposing metadata to user DoFn signatures.
  • Preventing Metadata Loss: The primary objective of the guide is to ensure that new metadata fields are correctly handled throughout the pipeline execution to prevent silent data loss.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .agent/skills/adding-new-metadata/SKILL.md
    • Added a new skill guide providing comprehensive instructions on how to add and propagate new metadata fields in Apache Beam's WindowedValue.
Activity
  • The pull request description includes standard contribution guidelines and CI status badges, but no specific human activity such as comments or reviews was provided in the context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @kennknowles added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@stankiewicz
Copy link
Contributor Author

R: @liferoad as you contributed a lot to skills.

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant