Skip to content

Add DATE/TIME/DATETIME to portable LogicalTypes.Enum in schema.proto#37870

Closed
brucearctor wants to merge 1 commit intoapache:masterfrom
brucearctor:portable-date-time-types
Closed

Add DATE/TIME/DATETIME to portable LogicalTypes.Enum in schema.proto#37870
brucearctor wants to merge 1 commit intoapache:masterfrom
brucearctor:portable-date-time-types

Conversation

@brucearctor
Copy link
Contributor

Summary

Add DATE, TIME, and DATETIME as standard portable logical types in LogicalTypes.Enum in schema.proto.

Motivation

The Java SDK already defines Date, Time, and DateTime logical types (SqlTypes.DATE/TIME/DATETIME) using java.time with portable URNs (beam:logical_type:date:v1, etc.), but these were never added to the proto's LogicalTypes.Enum. This means they can't be recognized as standard types during cross-language serialization — they degrade to UnknownLogicalType.

This is the first step toward full portable Date/Time support, which will unblock IcebergIO date type usage from the Python SDK.

Changes

  • DATE = 8 — epoch days as INT64 (matching Date.java)
  • TIME = 9 — nanoseconds as INT64 (matching Time.java)
  • DATETIME = 10 — ROW<Date: INT64, Time: INT64> (matching DateTime.java)

Follow-up PRs

  1. Register these in SchemaTranslation.STANDARD_LOGICAL_TYPES (Java)
  2. Add matching logical type classes in the Python SDK
  3. Update JdbcUtil.java to recognize the portable URNs alongside legacy identifiers

Related Issues

Add DATE (epoch days, INT64), TIME (nanoseconds, INT64), and
DATETIME (ROW<Date: INT64, Time: INT64>) as standard portable
logical types in the schema proto definition.

These logical types already exist in the Java SDK (SqlTypes.DATE,
SqlTypes.TIME, SqlTypes.DATETIME) with portable URNs but were
never added to LogicalTypes.Enum, preventing cross-language
recognition.

This is the first step toward full portable Date/Time support,
unblocking IcebergIO Date type usage from the Python SDK.

Fixes: apache#37823
See also: apache#25946, apache#28359
@github-actions github-actions bot added the model label Mar 16, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces standard portable logical types for DATE, TIME, and DATETIME into the schema.proto definition. This crucial update addresses the current limitation where existing Java SDK date/time types degrade to UnknownLogicalType during cross-language serialization, thereby enabling proper recognition and interoperability. This change is a foundational step towards full portable Date/Time support, specifically unblocking the use of IcebergIO date types from the Python SDK.

Highlights

  • New Logical Types: Added DATE, TIME, and DATETIME to LogicalTypes.Enum in schema.proto to enable standard portable date/time serialization.
  • DATE Type Definition: Defined DATE as an INT64 representing epoch days, matching Date.java.
  • TIME Type Definition: Defined TIME as an INT64 representing nanoseconds, matching Time.java.
  • DATETIME Type Definition: Defined DATETIME as a ROW<Date: INT64, Time: INT64>, matching DateTime.java.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema.proto
    • Added DATE = 8 with INT64 representation for epoch days.
    • Added TIME = 9 with INT64 representation for nanoseconds.
    • Added DATETIME = 10 with ROW<Date: INT64, Time: INT64> representation.
Activity
  • No human activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @shunping added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: add native, portable support for the Date data type within the Beam IcebergIO, ensuring it works smoothly from the Python SDK.

1 participant