Skip to content

Adds validates runner post commit tests for Java streaming worker on streaming engine#37872

Merged
kennknowles merged 3 commits intoapache:masterfrom
acrites:validates-runner-streaming-engine
Mar 17, 2026
Merged

Adds validates runner post commit tests for Java streaming worker on streaming engine#37872
kennknowles merged 3 commits intoapache:masterfrom
acrites:validates-runner-streaming-engine

Conversation

@acrites
Copy link
Contributor

@acrites acrites commented Mar 16, 2026

Previously, the only post commit validates runner test suite we had for the Java streaming worker was running against appliance.

These changes are modeled from 0699f35.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the testing infrastructure for the Apache Beam Java streaming worker by introducing a dedicated post-commit validation test suite for the streaming engine. This new suite complements the existing appliance-based tests, ensuring more comprehensive and specific validation of streaming functionalities when executed on the Dataflow streaming engine.

Highlights

  • New Test Suite: A new post-commit validates runner test suite has been introduced.
  • Targeted Testing: This new suite specifically targets the Java streaming worker when running on the streaming engine.
  • Expanded Coverage: The change expands test coverage beyond the previously existing appliance-based tests for the Java streaming worker.
  • Implementation Model: The implementation of these changes is modeled after a similar previous commit.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming_Engine.json
    • Added a new trigger file for the beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming_Engine test.
  • runners/google-cloud-dataflow-java/build.gradle
    • Added a new Gradle task validatesRunnerStreamingEngine to run Dataflow runner validation tests with the streaming engine enabled.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming_Engine.yml
Activity
  • No specific human activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @damccorm for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

]))
}

task validatesRunnerStreamingEngine {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW we could probably just alter the pipeline options with a -PforceStreamingEngine=true gradle property passing method or whatnot, as well. Mostly a matter of style, I think, or if we needed to customize a variety of aspects of the run, such as different test exclusions or other configuration that went along with using streaming engine.

@kennknowles kennknowles merged commit babf20c into apache:master Mar 17, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants