Move .js/.node precedence fix into isNodeApiModule, dedupe plist checks

- Replace the Babel-transform-time require.resolve() guard with a check
  inside isNodeApiModule itself, so the fix lives in the shared utility
  (also used by findNodeAddonForBindings) instead of duplicating Node's
  module resolution algorithm via a second, independent code path that
  could diverge from what Metro actually resolves at runtime.
- Verify the Info.plist contents with a zod schema instead of ad hoc
  "in" checks on an untyped object, matching how the rest of the repo
  validates untrusted structured data.
- Reuse the exported escapeBundleIdentifier instead of re-deriving the
  bundle-identifier escaping regex inline in the verify script, so the
  two can't silently drift apart.

Closes #424

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q1k6UQJPPaqKEKmnsRUatt

Author: claude

.changeset/calm-bears-resolve.md

@@ -2,4 +2,4 @@
 "react-native-node-api": patch
 ---
 
-Preserve Node.js module resolution precedence when a JavaScript file and native addon share a basename.
+Preserve Node.js module resolution precedence when a JavaScript file and native addon share a basename: `require('./foo')` no longer gets rewritten to load a Node-API addon when a same-named `foo.js`/`.cjs`/`.mjs`/`.json` file exists alongside it, since that source file is what `require()` actually resolves to. An explicit `require('./foo.node')` is unaffected.

packages/host/src/node/babel-plugin/plugin.ts

@@ -1,5 +1,4 @@
 import assert from "node:assert/strict";
-import { createRequire } from "node:module";
 import path from "node:path";
 
 import type { PluginObj, NodePath } from "@babel/core";
@@ -102,7 +101,6 @@ export function plugin(): PluginObj {
             }
           } else if (
             !path.isAbsolute(id) &&
-            !resolvesToNonNodeModule(id, this.filename) &&
             isNodeApiModule(path.join(from, id))
           ) {
             const relativePath = path.join(from, id);
@@ -116,11 +114,3 @@ export function plugin(): PluginObj {
     },
   };
 }
-
-function resolvesToNonNodeModule(id: string, filename: string): boolean {
-  try {
-    return !createRequire(filename).resolve(id).endsWith(".node");
-  } catch {
-    return false;
-  }
-}

packages/host/src/node/index.ts

@@ -20,6 +20,7 @@ export {
   createXCframework,
   createUniversalAppleLibrary,
   determineXCFrameworkFilename,
+  escapeBundleIdentifier,
 } from "./prebuilds/apple.js";
 
 export {

packages/host/src/node/path-utils.ts

@@ -59,13 +59,25 @@ export type NamingStrategy = {
 // Cache mapping package directory to package name across calls
 const packageNameCache = new Map<string, string>();
 
+// Extensions Node's own require() resolves before ever trying `.node`.
+const COLLIDING_SOURCE_EXTENSIONS = [".js", ".cjs", ".mjs", ".json"];
+
 /**
  * @param modulePath  Batch-scans the path to the module to check (must be extensionless or end in .node)
  * @returns True if a platform specific prebuild exists for the module path, warns on unreadable modules.
  * @throws If the parent directory cannot be read, or if a detected module is unreadable.
  * TODO: Consider checking for a specific platform extension.
  */
 export function isNodeApiModule(modulePath: string): boolean {
+  if (
+    !modulePath.endsWith(".node") &&
+    COLLIDING_SOURCE_EXTENSIONS.some((extension) =>
+      fs.existsSync(modulePath + extension),
+    )
+  ) {
+    // An explicit require('./foo.node') has no such ambiguity to defer to.
+    return false;
+  }
   {
     // HACK: Take a shortcut (if applicable): existing `.node` files are addons
     try {

packages/node-addon-examples/package.json

@@ -38,6 +38,7 @@
   },
   "dependencies": {
     "assert": "^2.1.0",
-    "react-native-node-api": "workspace:*"
+    "react-native-node-api": "workspace:*",
+    "zod": "^4.1.11"
   }
 }

packages/node-addon-examples/scripts/verify-prebuilds.mts

@@ -3,9 +3,21 @@ import assert from "node:assert/strict";
 import path from "node:path";
 
 import plistModule from "@expo/plist";
+import { escapeBundleIdentifier } from "react-native-node-api";
+import { z } from "zod";
 
 import { EXAMPLES_DIR } from "./cmake-projects.mjs";
 
+// @expo/plist is CJS with an `export default`; under this genuine ESM
+// (.mts) module's interop, the default import binds to the whole
+// `module.exports`, nesting the real API one `.default` deeper.
+const plist = plistModule.default;
+
+const FrameworkInfoPlistSchema = z.object({
+  CFBundleExecutable: z.string(),
+  CFBundleIdentifier: z.string(),
+});
+
 const EXPECTED_ANDROID_ARCHS = ["armeabi-v7a", "arm64-v8a", "x86_64", "x86"];
 
 const EXPECTED_XCFRAMEWORK_PLATFORMS = [
@@ -39,6 +51,27 @@ async function verifyAndroidPrebuild(dirent: fs.Dirent) {
   }
 }
 
+async function verifyFrameworkInfoPlist(
+  infoPlistPath: string,
+  libraryName: string,
+) {
+  const contents = await fs.promises.readFile(infoPlistPath, "utf8");
+  const parsed = FrameworkInfoPlistSchema.parse(plist.parse(contents));
+  assert.equal(
+    parsed.CFBundleExecutable,
+    libraryName,
+    `Unexpected CFBundleExecutable in ${infoPlistPath}`,
+  );
+  assert.equal(
+    parsed.CFBundleIdentifier,
+    // Mirrors the default writeFrameworkInfoPlist derives in
+    // packages/host/src/node/prebuilds/apple.ts, since none of the
+    // examples pass --apple-bundle-identifier.
+    escapeBundleIdentifier(`com.callstackincubator.node-api.${libraryName}`),
+    `Unexpected CFBundleIdentifier in ${infoPlistPath}`,
+  );
+}
+
 async function verifyApplePrebuild(dirent: fs.Dirent) {
   console.log("Verifying Apple prebuild", dirent.name, "in", dirent.parentPath);
   for (const arch of EXPECTED_XCFRAMEWORK_PLATFORMS) {
@@ -68,27 +101,10 @@ async function verifyApplePrebuild(dirent: fs.Dirent) {
           );
           if (file.name === "Info.plist") {
             const libraryName = path.basename(frameworkDir, ".framework");
-            const infoPlist: unknown = plistModule.default.parse(
-              await fs.promises.readFile(
-                path.join(frameworkDir, file.name),
-                "utf8",
-              ),
-            );
-            assert(
-              typeof infoPlist === "object" && infoPlist !== null,
-              "Expected Info.plist to contain a dictionary",
-            );
-            assert("CFBundleExecutable" in infoPlist);
-            assert("CFBundleIdentifier" in infoPlist);
-            assert.equal(infoPlist.CFBundleExecutable, libraryName);
-            assert.equal(
-              infoPlist.CFBundleIdentifier,
-              `com.callstackincubator.node-api.${libraryName}`.replace(
-                /[^A-Za-z0-9-.]/g,
-                "-",
-              ),
+            await verifyFrameworkInfoPlist(
+              path.join(frameworkDir, file.name),
+              libraryName,
             );
-            continue;
           } else {
             assert(
               !file.name.endsWith(".node"),