Repository navigation
test(bundle): drive checkOrgMember's missing payload.repository guard (auth.ts:43-45) through dist/index.js - #447
Open
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
… (auth.ts:43-45) through dist/index.js Two issue_comment /assign runs whose payload has no repository object: a collaborator is still assigned (the org read is skipped, context.repo falls back to GITHUB_REPOSITORY) and a stranger fails with no authorized users. Both assert the guard's debug line and that no /orgs/ read is made. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
Contributor
|
Please add a kind label with |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
__tests__/bundle/orgMemberRepositoryGuard.test.ts: twoissue_comment/assignruns throughdist/index.jswhose payload has norepositoryobject, the only way to reachcheckOrgMember's guard atsrc/utils/auth.ts:43-45.checkOrgMember error: context payload repository undefinedis logged, noGET /orgs/…),context.repofalls back toGITHUB_REPOSITORY, and the collaborator read, comment read and assignee write follow in orderno authorized users foundafter the same two reads and no writeUnder
npm run test:coverage:e2ethe arm goes from 0 to 2 hits. Test-only change;dist/is untouched (npm run build && npm run packleaves it clean), lint passes.Related Issue
Closes #446
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88