✨ Allow setting lights to be on overnight

Remove restriction, do some smarter calculations

Author: cp2004

octoprint_ws281x_led_status/runner/timer.py

@@ -31,7 +31,7 @@ def __init__(self, settings, callback):
         if settings["enabled"]:
             # Only create the timer if necessary, as minimal logic as possible
             self.timer = self.timer = RepeatedTimer(
-                30,  # TODO reduce to 30
+                30,
                 self.check_times,
                 run_first=True,
             )
@@ -59,10 +59,10 @@ def check_times(self):
         end = datetime.now().replace(hour=self.end_time[0], minute=self.end_time[1])
 
         if not (end - start).total_seconds() > 0:
-            # If start is not before end, this is not supported & lights will always be on
-            # Don't even bother trying to calculate it..
-            self.switch(True)
-            return
+            # If end is before start,
+            # then the lights are configured to be on overnight
+            # so we will subtract one day from the start and call it yesterday
+            start = start.replace(day=start.day - 1)
 
         current = datetime.now()
 

octoprint_ws281x_led_status/templates/settings/features.jinja2

@@ -21,7 +21,6 @@
         </label>
     </div>
     <p class="help-block">The LED strip will turn on at the start time, off at the end time. Potentially useful if you don't want them on overnight.</p>
-    <p data-bind="visible: {{ binding.bind_setting("features.active_times.enabled") }}" class="help-block">Note this currently doesn't support the start time being later than end time(eg. 19:00 to 13:00), your LEDs will always be off.</p>
     <div class="alert alert-block" data-bind="visible: {{ binding.bind_setting("features.active_times.enabled") }}">
         <h4>Heads up!</h4>
         <p>The plugin uses your system time, so this depends on a correct timezone which may not have been changed from the default.