ai: apply changes for #915 (1 review thread)

Addresses:
  - #3802255225 at src/databricks/sql/session.py:93

Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>

Author: peco-engineer-bot[bot]

src/databricks/sql/session.py

@@ -90,7 +90,18 @@ def _kernel_host_and_path(
         # present, so add a temporary one when the host is scheme-less.
         host = server_hostname.rstrip("/")
         probe = host if "://" in host else "https://" + host
-        if urlsplit(probe).port is None:
+        try:
+            existing_port = urlsplit(probe).port
+        except ValueError as exc:
+            # ``SplitResult.port`` raises when the authority carries a
+            # non-numeric or out-of-range port. Re-raise as a clear,
+            # connector-side error consistent with the ``_connection_uri``
+            # validation above, instead of leaking an opaque URL-parsing error.
+            raise ValueError(
+                "Invalid server_hostname {!r}: could not parse its port "
+                "({})".format(server_hostname, exc)
+            )
+        if existing_port is None:
             host = "{}:{}".format(host, port)
         return host, http_path
 

tests/unit/test_session.py

@@ -834,3 +834,12 @@ def test_port_folded_into_ipv6_literal_without_port(self):
     def test_port_not_double_appended_for_ipv6_literal_with_port(self):
         host, _ = _kernel_host_and_path("[::1]:7000", self.PATH, {"_port": 8443})
         assert host == "[::1]:7000"
+
+    def test_malformed_port_in_hostname_raises_clear_error(self):
+        # A non-numeric/out-of-range port on server_hostname makes
+        # ``SplitResult.port`` raise; surface a clear connector-side error
+        # instead of leaking an opaque URL-parsing ValueError.
+        with pytest.raises(ValueError, match="could not parse its port"):
+            _kernel_host_and_path(
+                self.HOST + ":notaport", self.PATH, {"_port": 8443}
+            )