From 42eb2cc4b8246f3ba6fea7133cbdba544d702eb2 Mon Sep 17 00:00:00 2001
From: Jan Rose <jan.rose@databricks.com>
Date: Mon, 3 Aug 2026 13:47:29 +0200
Subject: [PATCH] Stop reading the `valid` field from `auth profiles`
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The Databricks CLI is making `auth profiles` a pure config-file listing: it
no longer validates credentials, so the `valid` field in the JSON output is
going away (see databricks/cli#5216).

Drop `ConfigEntry.valid`. It was parsed out of the JSON but never read
anywhere, so nothing behavioural changes — this just stops depending on a
field that is disappearing.

`--skip-validate` is deliberately kept: older CLIs (the extension pins
1.9.0) still validate every profile here, which is slow and can hang on an
unreachable host, and newer CLIs accept the flag as a hidden no-op. Passing
it stays correct across both.

`authType` also keeps working: the CLI infers auth_type from the config
file keys, so profile auth types still render in the login wizard.

Co-authored-by: Isaac
---
 packages/databricks-vscode/src/cli/CliWrapper.ts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/packages/databricks-vscode/src/cli/CliWrapper.ts b/packages/databricks-vscode/src/cli/CliWrapper.ts
index 64bc9534e..bdd9d2025 100644
--- a/packages/databricks-vscode/src/cli/CliWrapper.ts
+++ b/packages/databricks-vscode/src/cli/CliWrapper.ts
@@ -166,7 +166,6 @@ export interface ConfigEntry {
     workspaceId?: string;
     cloud: Cloud;
     authType: string;
-    valid: boolean;
 }
 
 export type SyncType = "full" | "incremental";
@@ -479,6 +478,10 @@ export class CliWrapper {
     }
 
     private getListProfilesCommand(): Command {
+        // Keep --skip-validate: older CLIs still validate every profile here,
+        // which makes listing slow and can hang on an unreachable host. Newer
+        // CLIs never validate and accept the flag as a hidden no-op, so passing
+        // it is correct for both (see databricks/cli#5216).
         return {
             command: this.cliPath,
             args: [
@@ -544,7 +547,6 @@ export class CliWrapper {
                     workspaceId: profile.workspace_id,
                     cloud: profile.cloud,
                     authType: profile.auth_type,
-                    valid: profile.valid,
                 });
             } catch (e: unknown) {
                 let msg: string;