Skip to content

Extent2D and Extent3D should implement IEquatable #2276

Description

@StefanPoelloth

Summary of feature

Silk.NET.Vulkan.Extent2D and Silk.NET.Vulkan.Extent3D should implement IEquatable.

Comments

There might be other structs that would benefit from the implementation.

In my code I'm comparing 2 Silk.NET.Vulkan.Extent2D with currentSize.Equals(displaySize) to check if some resources should be recreated.
As a workaround i changed my code to compare the individual fields.

Output from resharper code inspection:

warning: Struct 'Extent2D' is checked for equality using the inefficient runtime-provided implementation
Default implementations of the 'Equals' and 'GetHashCode' methods of a struct are reflection-based and bad-performing

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions