Repository navigation
Add net10.0 to CI test matrix (#7690) - #7743
Open
architdhakar wants to merge 6 commits into
Open
architdhakar wants to merge 6 commits into
architdhakar wants to merge 6 commits into
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
Author
|
@dotnet-policy-service agree |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Helix payloads and custom architecture matrices do not yet guarantee .NET 10 coverage and runtime availability.
Review effort: Lite
Findings: 3
Open (4)
What changed in this PR
Adds .NET 10 test targeting and CI matrix coverage while retaining .NET 8 compatibility.
Changes:
- Adds
net10.0test targeting. - Registers the .NET 10 runtime version.
- Updates CI matrices with .NET 10 and explicit .NET 8 jobs.
| File | Description |
|---|---|
test/Directory.Build.props |
Enables .NET 10 test targets. |
global.json |
Adds .NET 10 runtime metadata. |
eng/Versions.props |
Defines the .NET 10 runtime version. |
build/ci/job-template.yml |
Updates CI matrix targets. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| _config_short: D | ||
| _includeBenchmarkData: false | ||
| _targetFramework: net8.0 | ||
| _targetFramework: net10.0 |
| <BenchmarkDotNetVersion>0.13.12</BenchmarkDotNetVersion> | ||
| <DotNetRuntime60Version>6.0.36</DotNetRuntime60Version> | ||
| <DotNetRuntime80Version>8.0.16</DotNetRuntime80Version> | ||
| <DotNetRuntime100Version>10.0.0</DotNetRuntime100Version> |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7743 +/- ##
==========================================
- Coverage 70.81% 70.81% -0.01%
==========================================
Files 1421 1421
Lines 280000 279998 -2
Branches 27620 27620
==========================================
- Hits 198290 198276 -14
- Misses 73549 73563 +14
+ Partials 8161 8159 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7690
Summary
net10.0to supported test target frameworks intest/Directory.Build.props.global.jsonandeng/Versions.props.build/ci/job-template.ymlto setnet10.0as the default test target while keeping explicitnet8.0matrix coverage.