Localize Faker::Job for de, de-CH, fr, fr-CH and it#3272
Open
huerlisi wants to merge 1 commit into
Open
Conversation
`Faker::Job` only had data for en (and hy, pt-BR), so every other locale silently returned English titles, e.g. `it` produced "Lead Banking Developer" and `de` produced "Design Administrator". Add localized `job` data for the German, French and Italian locales. Each provides the keys `Faker::Job` consumes — `field`, `seniority`, `position`, `key_skills` — plus a `title` template reordered to fit the language (adjective-after-noun for fr/it, e.g. "Directeur Régional", "Dirigente Contabilità"). As with the English generator, titles are synthetic combinations. `fr` follows the lib/locales/fr/ subfolder convention (new fr/job.yml); the other locales get a top-level `job:` block. `de-CH`/`fr-CH` carry their own copies since they do not fall back to `de`/`fr`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
|
In the Should I keep as is, or is this the right moment to introduce a directory for the locales I touched? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Faker::Jobonly had data foren(andhy,pt-BR), so every otherlocale silently returned English job titles:
This Pull Request adds localized
jobdata for the German, French andItalian locales. Each provides the keys
Faker::Jobconsumes —field,seniority,position,key_skills— plus atitletemplate reorderedto fit the language (adjective-after-noun for fr/it). As with the English
generator, titles are synthetic combinations.
Additional information
Output after the change:
Notes:
frfollows thelib/locales/fr/subfolder convention (newfr/job.yml); the other locales get a top-leveljob:block.de-CH/fr-CHcarry their own copies because they do not fall back tode/fr.Faker::Jobare included (employment_type/education_levelare not read by anyFaker::Jobmethod).Tests assert
Faker::Job.fieldis a member of the locale's own field list,guarding against a regression back to the English fallback.
Checklist