Skip to content

Commit 49defc3

Browse files
committed
Removing a redundant test
Signed-off-by: Rodolfo Carvalho <[email protected]>
1 parent db439da commit 49defc3

File tree

2 files changed

+6
-25
lines changed

2 files changed

+6
-25
lines changed

flytekit-testing/src/main/java/org/flyte/flytekit/testing/SdkTestingExecutor.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,19 +117,18 @@ public static SdkTestingExecutor of(
117117
}
118118

119119
/**
120-
* Creates a new {@link SdkTestingExecutor} for testing a {@link SdkDynamicWorkflowTask}.
121-
* This method wraps the given dynamic workflow task and its input into a delegating workflow,
122-
* allowing the task to be executed and tested in isolation.
120+
* Creates a new {@link SdkTestingExecutor} for testing a {@link SdkDynamicWorkflowTask}. This
121+
* method wraps the given dynamic workflow task and its input into a delegating workflow, allowing
122+
* the task to be executed and tested in isolation.
123123
*
124124
* @param task the dynamic workflow task to test
125125
* @param input the input to the dynamic workflow task
126126
* @param outputType the expected output type of the dynamic workflow task
127127
* @param <InputT> the type of the input
128128
* @param <OutputT> the type of the output
129129
* @return a new {@link SdkTestingExecutor} instance
130-
*
131-
* <p>Example usage:
132-
* <pre>{@code
130+
* <p>Example usage:
131+
* <pre>{@code
133132
* int expected = 6;
134133
*
135134
* SumIfEvenDynamicWorkflowTask.Output output =

flytekit-testing/src/test/java/org/flyte/flytekit/testing/SdkDynamicWorkflowTaskDelegatingWorkflowTest.java

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public void testDelegatingWorkflow_EvenValues() {
4242
}
4343

4444
@Test
45-
public void testDelegatingWorkflow_OddA() {
45+
public void testDelegatingWorkflow_Odd() {
4646
int expected = 0;
4747

4848
SumIfEvenDynamicWorkflowTask.Output output =
@@ -58,22 +58,4 @@ public void testDelegatingWorkflow_OddA() {
5858
.getOutputAs(JacksonSdkType.of(SumIfEvenDynamicWorkflowTask.Output.class));
5959
assertEquals(expected, output.c().get());
6060
}
61-
62-
@Test
63-
public void testDelegatingWorkflow_OddB() {
64-
int expected = 0;
65-
66-
SumIfEvenDynamicWorkflowTask.Output output =
67-
SdkTestingExecutor.of(
68-
new SumIfEvenDynamicWorkflowTask(),
69-
SumIfEvenDynamicWorkflowTask.Input.create(of(2), of(5)),
70-
JacksonSdkType.of(SumIfEvenDynamicWorkflowTask.Output.class))
71-
.withTaskOutput(
72-
new SumTask(),
73-
SumTask.SumInput.create(of(0), of(0)),
74-
SumTask.SumOutput.create(of(expected)))
75-
.execute()
76-
.getOutputAs(JacksonSdkType.of(SumIfEvenDynamicWorkflowTask.Output.class));
77-
assertEquals(expected, output.c().get());
78-
}
7961
}

0 commit comments

Comments
 (0)