release: 2.4.4 (#433)

Author: devxb

src/main/kotlin/org/gitanimals/rank/controller/RankController.kt

@@ -8,6 +8,7 @@ import org.gitanimals.rank.controller.response.RankTotalCountResponse
 import org.gitanimals.rank.domain.RankQueryRepository
 import org.gitanimals.rank.domain.history.RankHistoryService
 import org.gitanimals.rank.domain.response.RankResponse
+import org.slf4j.LoggerFactory
 import org.springframework.http.ResponseEntity
 import org.springframework.web.bind.annotation.GetMapping
 import org.springframework.web.bind.annotation.PathVariable
@@ -21,6 +22,8 @@ class RankController(
     private val rankHistoryService: RankHistoryService,
 ) {
 
+    private val logger = LoggerFactory.getLogger(this::class.simpleName)
+
     @GetMapping("/ranks")
     fun findAllRanks(
         @RequestParam("rank") rank: Int,
@@ -35,12 +38,12 @@ class RankController(
     ): ResponseEntity<out Any> {
         return runCatching {
             ResponseEntity.ok(getRankByUsernameFacade.invoke(username))
-        }.getOrElse {
+        }.getOrElse { exception ->
+            logger.info(exception.message, exception)
+
             ResponseEntity
                 .badRequest()
-                .body(
-                    ErrorResponse("Cannot find rank by username: \"$username\"")
-                )
+                .body(ErrorResponse("Cannot find rank by username: \"$username\""))
         }
     }
 

src/main/kotlin/org/gitanimals/render/infra/HttpClientErrorHandler.kt

@@ -10,7 +10,6 @@ import org.gitanimals.core.ratelimit.RateLimitable
 import org.gitanimals.core.slack.SlackSender
 import org.gitanimals.supports.ratelimit.InmemoryGithubRateLimiter.CoroutineDispatcher.coroutineContext
 import org.slf4j.LoggerFactory
-import org.springframework.scheduling.annotation.Scheduled
 import org.springframework.stereotype.Component
 import java.util.concurrent.Executors
 import java.util.concurrent.TimeUnit