Repository navigation
[Schema Consistency] 🔍 Schema Consistency Check - 2026-11-20 #79439
Closed
Replies: 1 comment
|
This discussion has been marked as outdated by Schema Consistency Checker. A newer discussion is available at Discussion #79720. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Summary
Critical issues
No critical issue was established in this targeted review.
Key findings
Schema accepts zero for guardrails that the compiler discards. Schema uses
templatable_integerfor top-levelmax-turnsandmax-tool-denials, whose integer minimum is zero (definition). The deprecatedengine.max-turnsuses it too. Both parser helpers require at least one (engine_config_parser.go, line 121); zero becomes an empty value and is treated as unset. Copilot SDK then uses its default denial threshold (copilot_engine_execution.go), while turn limits fall back to default resolution. An author may believe a configured limit is in force. Change these properties to a positive-integer schema, or deliberately implement and document zero semantics; add schema and compiler tests covering top-level and nested values.The generated full reference supplies invalid string examples. frontmatter-full.md shows
example-valueas the string format formax-turns,max-tool-denials,max-tool-calls,max-ai-credits, andmax-daily-ai-credits. The first three require an Actions expression; credit strings require a positive number with optional K/M suffix, an expression, or-1(schema definitions). The generator falls back toexample-valuefor strings (generate-schema-docs.js). Generate pattern-aware examples or use schema examples, and validate generated variants in a test.The glossary excludes supported Pi guardrails. The max-tool-denials glossary says the setting only applies to Copilot SDK, and the max-tool-calls glossary says other engines are unsupported. The compiler accepts these fields for built-in Pi drivers; the Pi reference and Pi smoke workflow corroborate that support. Update both glossary entries to include Pi and the built-in driver restrictions.
The AI credits reference describes an invalid disable value. The frontmatter reference says to set
max-ai-creditsto a negative value to disable enforcement. The schema and typed parser accept only-1as the negative sentinel; for example,-2is rejected. Change the text to specify-1.Scope and field-gap observations
The precomputed diff reports no top-level keys used by project workflows that are absent from the schema. The sampled Pi workflow uses positive guardrail values. This was a targeted source review, not a full compilation or validation of every workflow. The five schema fields absent from the tagged frontmatter struct are not by themselves defects: for example, connector declarations, Docker pull policy, and skip questions are read from raw frontmatter. No AWF config-source drift comparison is asserted.
Recommendations and next steps
Strategy performance
Field gaps plus constraint and data-flow tracing: 4 findings; effectiveness: high; reuse: yes. Raw-map tracing avoided false positives, while constraint tracing exposed silent zero handling and invalid examples.
References: §44680823863
All reactions