You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Inconsistencies found: 4; none assessed as critical.
Areas reviewed: schema, compiler/parser, documentation, and selected workflows.
Strategy: cached field gaps plus constraint and data-flow tracing; new strategy: no.
Scope: targeted static review, not exhaustive validation or a live workflow run. The precomputed inventory reports no top-level workflow keys missing from the schema. Struct-tag gaps alone are not defects: several fields are handled through raw frontmatter.
AWF warning: canonical source retrieval failed, so the AWF config comparison is degraded and non-authoritative; no AWF drift conclusion is asserted.
Critical Issues
None established in this review.
Documentation Gaps and Schema Improvements Needed
Schema accepts skip questions that the compiler rejects.pkg/parser/schemas/main_workflow_schema.json:39 checks only string type, non-whitespace content and list length, while pkg/workflow/skip_if_decision.go:26 rejects any question containing ${{. An editor can accept a question such as Is ${{ github.event_name }} irrelevant? that fails compilation; docs/src/content/docs/reference/frontmatter.md:88 already documents the restriction. Add a schema constraint excluding ${{ and a regression case for both schema and compiler.
Generated reference repeats mutually exclusive keys in one YAML block.docs/src/content/docs/reference/frontmatter-full.md:3284 and :3312 show both forms of engine.model-routing at the same indentation; :25842 and :25845 do the same for top-level model-routing. Duplicate keys can be rejected by the parser or silently overwrite an alternative in other YAML readers. Generate alternatives as separate snippets or comment out all but one, and validate the generated block for duplicate keys.
Generated reference contains schema-invalid individual examples.docs/src/content/docs/reference/frontmatter-full.md:25 shows connectors: {}, but the schema requires at least one property (pkg/parser/schemas/main_workflow_schema.json:27). The reference gives source-sha: example-value at :87, but the schema requires 40 hexadecimal characters (pkg/parser/schemas/main_workflow_schema.json:240). The shortlist example at :25845 has an empty allowed-models, although its referenced schema requires at least one item (pkg/parser/schemas/main_workflow_schema.json:15780). Generate valid representative values or clearly mark placeholders and validate generated fragments against their subschemas.
Image-manifest routing guidance is stale.docs/src/content/docs/reference/sandbox.md:294 says the router role is required when engine.model-routing is set. Routing can instead be selected by model: router or by the implicit default (docs/src/content/docs/reference/model-routing.md:13 and :65), and the compiler requires the role whenever routing is enabled (pkg/workflow/sandbox_agent_images.go:152). The compiler can also fill missing default image pins (:92), so the documentation should describe the effective manifest and auto-filled defaults rather than imply that every missing role must always be manually supplied.
Parser Updates Required
No parser change is required for the demonstrated skip-expression rejection; keep schema and parser regression coverage aligned.
Workflow Violations
No violation was established in the selected workflow examples. For example, .github/workflows/smoke-copilot-routed.md:27 combines an explicit router model with a nonempty shortlist. This is not a full workflow validation.
Recommendations
Align skip-question schema validation with compiler rejection and add regression coverage.
Fix generated reference alternatives and schema-invalid values; validate generated examples and duplicate keys in documentation generation.
Update sandbox image-manifest guidance for explicit and implicit routing, including compiler-filled pins.
Strategy Performance
Strategy used: field gaps plus constraint and data-flow tracing.
Findings: 4; effectiveness: high; reuse: yes.
Next Steps
Align schema validation and regression coverage.
Correct and validate generated reference examples.
Update sandbox routing documentation.
Re-run the AWF comparison when canonical sources are available.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
🔍 Schema Consistency Check - 2026-11-21
Summary
Critical Issues
None established in this review.
Documentation Gaps and Schema Improvements Needed
pkg/parser/schemas/main_workflow_schema.json:39checks only string type, non-whitespace content and list length, whilepkg/workflow/skip_if_decision.go:26rejects any question containing${{. An editor can accept a question such asIs ${{ github.event_name }} irrelevant?that fails compilation;docs/src/content/docs/reference/frontmatter.md:88already documents the restriction. Add a schema constraint excluding${{and a regression case for both schema and compiler.docs/src/content/docs/reference/frontmatter-full.md:3284and:3312show both forms ofengine.model-routingat the same indentation;:25842and:25845do the same for top-levelmodel-routing. Duplicate keys can be rejected by the parser or silently overwrite an alternative in other YAML readers. Generate alternatives as separate snippets or comment out all but one, and validate the generated block for duplicate keys.docs/src/content/docs/reference/frontmatter-full.md:25showsconnectors: {}, but the schema requires at least one property (pkg/parser/schemas/main_workflow_schema.json:27). The reference givessource-sha: example-valueat:87, but the schema requires 40 hexadecimal characters (pkg/parser/schemas/main_workflow_schema.json:240). The shortlist example at:25845has an emptyallowed-models, although its referenced schema requires at least one item (pkg/parser/schemas/main_workflow_schema.json:15780). Generate valid representative values or clearly mark placeholders and validate generated fragments against their subschemas.docs/src/content/docs/reference/sandbox.md:294says the router role is required whenengine.model-routingis set. Routing can instead be selected bymodel: routeror by the implicit default (docs/src/content/docs/reference/model-routing.md:13and:65), and the compiler requires the role whenever routing is enabled (pkg/workflow/sandbox_agent_images.go:152). The compiler can also fill missing default image pins (:92), so the documentation should describe the effective manifest and auto-filled defaults rather than imply that every missing role must always be manually supplied.Parser Updates Required
No parser change is required for the demonstrated skip-expression rejection; keep schema and parser regression coverage aligned.
Workflow Violations
No violation was established in the selected workflow examples. For example,
.github/workflows/smoke-copilot-routed.md:27combines an explicit router model with a nonempty shortlist. This is not a full workflow validation.Recommendations
Strategy Performance
Next Steps
References: §44870705409
All reactions