Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
|
Review ETA: 9/28 EOD Availability: |
|
Review ETA: 09/30/2026 EOD |
|
Hi @KyleA99, thank you for working on this! I tested the PR locally and also read your comment about the styling. I was able to see the same things you mentioned. The three location cards are showing in separate rows, the horizontal line is missing, and the subheadings look different from the mockup. I understand that you were not sure if you should add new CSS classes for these changes. I think it would be good to ask the team how they want to handle the styling. I also noticed one small thing. The issue says “Our Locations,” but the mockup says “Our Location,” and the current PR also says “Our Location.” Maybe we should confirm which title we should use. Thank you! |
|
@egcuriel @nathanjkim-codes agreed with the "Location" -> "Locations" change. I fixed that. I'm assuming this was correct, and if it isnt, merge team will address. |
|
Review ETA: 09/30/2026 EOD |
egcuriel
left a comment
There was a problem hiding this comment.
Hi @KyleA99,
As you mentioned your comments there some discrepancies between the mockup and the changes requested on the parent issue. You've followed the instructions on the parent issue, so I approve. If there is any new changes please request a review from me. Thank you!
Fixes #8431
What changes did you make?
I created a new
about-card-our-locations.htmlfile in_includes/about-page/I created a new
our-locations-images.htmlfile in_includes/about-page/I added the new
about-card-our-locations.htmlfile to/pages/about.htmlI added a new li for the new card to the sticky-nav element
Note: Please see the comment I made regarding potential deficiencies in this pull request.
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied