Upgrade rubocop

Author: ixti

.rubocop.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-performance
   - rubocop-rake
   - rubocop-rspec

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100`
-# on 2024-01-05 21:03:44 UTC using RuboCop version 1.57.2.
+# on 2025-06-09 03:21:47 UTC using RuboCop version 1.76.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -30,6 +30,15 @@ Layout/DotPosition:
     - 'spec/lib/http_spec.rb'
     - 'spec/support/http_handling_shared.rb'
 
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
+# URISchemes: http, https
+Layout/LineLength:
+  Exclude:
+    - 'lib/http/chainable.rb'
+    - 'spec/lib/http/options/proxy_spec.rb'
+
 # Offense count: 206
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
@@ -143,7 +152,7 @@ RSpec/AnyInstance:
   Exclude:
     - 'spec/lib/http/client_spec.rb'
 
-# Offense count: 4
+# Offense count: 3
 # This cop supports unsafe autocorrection (--autocorrect-all).
 RSpec/BeEq:
   Exclude:
@@ -189,7 +198,7 @@ RSpec/DescribeMethod:
 
 # Offense count: 136
 # This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: SkipBlocks, EnforcedStyle.
+# Configuration parameters: SkipBlocks, EnforcedStyle, OnlyStaticConstants.
 # SupportedStyles: described_class, explicit
 RSpec/DescribedClass:
   Exclude:
@@ -242,13 +251,6 @@ RSpec/ExpectInHook:
     - 'spec/lib/http/connection_spec.rb'
     - 'spec/lib/http/request/writer_spec.rb'
 
-# Offense count: 1
-# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
-# Include: **/*_spec*rb*, **/spec/**/*
-RSpec/FilePath:
-  Exclude:
-    - 'spec/regression_specs.rb'
-
 # Offense count: 6
 # Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns.
 RSpec/IndexedLet:
@@ -417,12 +419,3 @@ Style/OptionalBooleanParameter:
 Style/ZeroLengthPredicate:
   Exclude:
     - 'lib/http/features/auto_deflate.rb'
-
-# Offense count: 3
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
-# URISchemes: http, https
-Layout/LineLength:
-  Exclude:
-    - 'lib/http/chainable.rb'
-    - 'spec/lib/http/options/proxy_spec.rb'

Gemfile

@@ -27,10 +27,10 @@ group :test do
 
   gem "backports"
 
-  gem "rubocop", "~> 1.61.0"
-  gem "rubocop-performance", "~> 1.19.1"
-  gem "rubocop-rake", "~> 0.6.0"
-  gem "rubocop-rspec", "~> 2.24.1"
+  gem "rubocop",             "~> 1.76.0"
+  gem "rubocop-performance", "~> 1.25.0"
+  gem "rubocop-rake",        "~> 0.7.1"
+  gem "rubocop-rspec",       "~> 3.6.0"
 
   gem "simplecov",      require: false
   gem "simplecov-lcov", require: false

http.gemspec

@@ -27,15 +27,15 @@ Gem::Specification.new do |gem|
 
   gem.required_ruby_version = ">= 3.0"
 
-  gem.add_runtime_dependency "addressable",    "~> 2.8"
-  gem.add_runtime_dependency "http-cookie",    "~> 1.0"
-  gem.add_runtime_dependency "http-form_data", "~> 2.2"
+  gem.add_dependency "addressable",    "~> 2.8"
+  gem.add_dependency "http-cookie",    "~> 1.0"
+  gem.add_dependency "http-form_data", "~> 2.2"
 
   # Use native llhttp for MRI (more performant) and llhttp-ffi for other interpreters (better compatibility)
   if RUBY_ENGINE == "ruby"
-    gem.add_runtime_dependency "llhttp",     "~> 0.6.1"
+    gem.add_dependency "llhttp",     "~> 0.6.1"
   else
-    gem.add_runtime_dependency "llhttp-ffi", "~> 0.6.1"
+    gem.add_dependency "llhttp-ffi", "~> 0.6.1"
   end
 
   gem.metadata = {

lib/http/features/instrumentation.rb

@@ -57,11 +57,11 @@ def instrument(name, payload = {})
           end
         end
 
-        def start(_name, _payload)
+        def start(_name, _payload) # rubocop:disable Naming/PredicateMethod
           true
         end
 
-        def finish(_name, _payload)
+        def finish(_name, _payload) # rubocop:disable Naming/PredicateMethod
           true
         end
       end

lib/http/response.rb

@@ -113,11 +113,7 @@ def content_length
       value = @headers[Headers::CONTENT_LENGTH]
       return nil unless value
 
-      begin
-        Integer(value)
-      rescue ArgumentError
-        nil
-      end
+      Integer(value, exception: false)
     end
 
     # Parsed Content-Type header

spec/lib/http/client_spec.rb

@@ -15,7 +15,7 @@
     stubbed_client = Class.new(HTTP::Client) do
       def perform(request, options)
         stubbed = stubs[HTTP::URI::NORMALIZER.call(request.uri).to_s]
-        stubbed ? stubbed.call(request) : super(request, options)
+        stubbed ? stubbed.call(request) : super
       end
 
       def stubs

spec/lib/http/request/body_spec.rb

@@ -98,7 +98,7 @@
   describe "#each" do
     let(:chunks) do
       chunks = []
-      subject.each { |chunk| chunks << chunk.dup }
+      subject.each { |chunk| chunks << chunk.dup } # rubocop:disable Style/MapIntoArray
       chunks
     end
 

spec/support/ssl_helper.rb

@@ -11,7 +11,7 @@ class RootCertificate < ::CertificateAuthority::Certificate
     EXTENSIONS = {"keyUsage" => {"usage" => %w[critical keyCertSign]}}.freeze
 
     def initialize
-      super()
+      super
 
       subject.common_name  = "honestachmed.com"
       serial_number.number = 1