Fix bug in repeated collapse of empty bodies

The initial rendering of the empty body wrote '' to the format cache,
and observes it. The second rendering reads from the cache, but then
because the value is falsey it writes to the cache again! This write
side-effect in a computed on an observable is bad bad bad and breaks the
rendering.

We now properly distinguish cache presence, not just falsey-ness.

Author: pimterry

src/components/editor/content-viewer.tsx

@@ -142,11 +142,16 @@ export class ContentViewer extends React.Component<ContentViewerProps> {
 
         const { cache } = this.props;
         const cacheKey = this.formatter.cacheKey;
-        const cachedValue = cache.get(cacheKey) as ObservablePromise<string> | string | undefined;
+        const hasCachedValue = cache.has(cacheKey);
 
-        const renderingContent = cachedValue ||
-            this.formatter.render(this.contentBuffer, this.props.headers) as ObservablePromise<string> | string;
-        if (!cachedValue) cache.set(cacheKey, renderingContent);
+        let renderingContent: string | ObservablePromise<string>;
+        if (hasCachedValue) {
+            const cachedValue = cache.get(cacheKey) as ObservablePromise<string> | string;
+            renderingContent = cachedValue;
+        } else {
+            renderingContent = this.formatter.render(this.contentBuffer, this.props.headers) as ObservablePromise<string> | string;
+            cache.set(cacheKey, renderingContent);
+        }
 
         if (typeof renderingContent === 'string') {
             return renderingContent;

src/model/observable-cache.ts

@@ -24,6 +24,10 @@ export class ObservableCache<T extends {
         return this.#lazyInstData;
     }
 
+    has<K extends keyof T>(key: K): boolean {
+        return key in this.#data;
+    }
+
     get<K extends keyof T>(key: K): T[K] | undefined {
         return this.#data[key] as T[K] | undefined;
     }