Repository navigation
fix: keep selected plugins when installing a BoM - #452
Closed
josh-burton wants to merge 1 commit into
Closed
josh-burton wants to merge 1 commit into
josh-burton wants to merge 1 commit into
Conversation
The install prompt hides plugins that are not available in the selected BoM, but it used indexes from the full plugin list when reading the user's choices. This shifted later selections to different plugins, causing selected plugins to be removed and unselected plugins to be installed. Use the filtered plugin list when reading prompt selections. Also allow install flags alongside a positional BoM version and prevent an install-specific --version option from being handled as a request for the FlutterFire CLI version.
josh-burton
had a problem deploying
to
CI Environment
July 20, 2026 20:59 — with 
GitHub Actions
Failure
GitHub Actions
Failure
josh-burton
had a problem deploying
to
CI Environment
July 20, 2026 20:59 — with
GitHub Actions
Failure
GitHub Actions
Failure
josh-burton
had a problem deploying
to
CI Environment
July 20, 2026 20:59 — with
GitHub Actions
Failure
GitHub Actions
Failure
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
1 of 7 tasks
Contributor
Author
|
I've refreshed this fix against current upstream |
github-actions
Bot
added
the
Needs Attention
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes flutterfire install selecting the wrong plugins when installing a FlutterFire BoM.
The plugin prompt filters out packages unavailable in the selected BoM, but the selected indexes were being applied to the full plugin list. This shifted later selections,
causing selected plugins to be removed and other plugins to be installed instead.
Changes
Testing
Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore